legacyConfig was removed from InstallContext in the config-legacy-removal
refactor but the SDK test helper was not updated, causing build failure.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(speech): STT not working when plugin settings missing groqApiKey
Fixes two bugs reported in #198 where STT feature does not work despite
being marked as configured.
Bug 1: speech plugin setup() now falls back to reading the API key from
legacy config.json (ctx.config) when groqApiKey is absent from plugin
settings. This handles users who upgraded OpenACP without reinstalling
the speech plugin, so the install() migration was never triggered. A
warn log is emitted to guide permanent migration via
`openacp plugin configure @openacp/speech`.
Bug 2: createConfigSection now uses SpeechService.isSTTAvailable() from
the ServiceRegistry to determine STT status, rather than reading from the
legacy config.json field. This ensures the assistant status snapshot
reflects actual runtime state instead of showing a false positive.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* docs: add config legacy removal design spec
Spec for two-phase removal of legacy config sections from ConfigSchema,
env var deduplication, and plugin self-declaring editable fields.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* refactor: remove legacy sections from ConfigSchema
Remove channels, agents, security, api, tunnel, usage, speech sections.
These now live exclusively in plugin settings files.
BaseChannelSchema, AgentSchema, TunnelSchema, UsageSchema, SpeechSchema
and their exported types are deleted.
DEFAULT_CONFIG simplified to core-only fields.
* fix: update all files referencing removed ConfigSchema fields
Replace config.agents/security/api/tunnel/speech/channels references
with agents.json reads or plugin settings reads. Fixes TypeScript errors
from ConfigSchema cleanup in previous commit.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* refactor: remove legacy config migrations
Keep only add-instance-name migration (needed for new installs).
Delete plugin-config-migration.ts (unused scaffolding, never integrated).
* refactor: remove plugin-mapped fields from config-registry
Remove: channels.telegram.outputMode, channels.discord.outputMode,
tunnel.enabled, security.maxConcurrentSessions, security.sessionTimeoutMinutes,
speech.stt.provider, speech.stt.apiKey.
Remove plugin? field from ConfigFieldDef — plugins self-declare via
registerEditableFields() in Phase 2.
Remove getFieldValueAsync, slim setFieldValueAsync to 3 params.
* refactor: config-editor reads/writes plugin fields via settings only
Drop config.json fallback in editTelegram, editSecurity, editApi, editTunnel.
These functions now exclusively use SettingsManager for plugin-owned fields.
* test: remove legacy config test cases
Delete: config-env-overrides.test.ts (channel token env overrides),
config-registry-plugin.test.ts (getFieldValueAsync, plugin-mapped setFieldValueAsync)
Trim: config-migrations.test.ts (keep only add-instance-name),
config-registry.test.ts (remove tunnel/channels assertions),
install-context.test.ts and plugin-setup-integration.test.ts
(remove legacyConfig test cases).
Also trim pre-existing failures from Phase 1 schema changes:
config-schema.test.ts (remove channels/api/security refs),
config-workspace.test.ts (remove channels/security/tunnel env override tests),
api-server.test.ts (update mock config, 429 test, PATCH config test),
routes-sessions.test.ts (fix 429 via lifecycleManager.settingsManager mock),
setup-integration.test.ts (remove channels/agents/security assertions),
helpers.test.ts and setup-channels.test.ts (remove legacy config.channels tests),
config-section.test.ts (remove legacy speech provider tests),
multi-instance-plumbing.test.ts (remove migrate-agents-to-store test).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat: add FieldDef type and registerEditableFields to PluginContext
Plugins can now declare their editable settings fields in setup():
ctx.registerEditableFields([
{ key: 'botToken', displayName: 'Bot Token', type: 'string', scope: 'sensitive' },
])
Fields are stored in PluginFieldRegistry (service: 'field-registry').
Requires 'commands:register' permission.
* refactor: remove legacyConfig from InstallContext
Plugin install() hooks no longer receive legacy config.json data.
Interactive setup is the only install path going forward.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* refactor: remove legacyConfig from telegram, security, speech plugins
Each plugin's install() now has only the interactive setup path.
Added registerEditableFields() calls in each plugin's setup() hook.
Remove speech legacy config fallback (config.speech no longer exists).
Also export FieldDef from @openacp/cli public API and add
registerEditableFields() no-op stub to createTestContext() in plugin-sdk.
Remove speech-plugin-setup test case for legacy config fallback path.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* refactor: remove legacyConfig from tunnel, api-server, file-service plugins
Completes legacyConfig removal from all plugins.
Added registerEditableFields() to each plugin's setup() hook.
Added commands:register permission to api-server and file-service plugins
to satisfy registerEditableFields() permission requirement.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat: export FieldDef from plugin-sdk
Plugin authors can import FieldDef from @openacp/plugin-sdk to type
their registerEditableFields() calls.
* fix: add commands:register to telegram, clean up dead legacyConfig in main.ts, update plugin template
- Add missing commands:register permission to telegram plugin (required by registerEditableFields)
- Remove dead legacyConfig variable from autoRegisterBuiltinPlugins in main.ts
- Remove legacyConfig documentation from plugin template (field removed from InstallContext)
* test: add missing coverage for config legacy removal
- config-registry: exact 5-field count, removed plugin fields absent,
setFieldValueAsync 3-arg API with return values and validation
- config-schema: removed fields (channels, security, tunnel) are stripped,
outputMode and agentSwitch core fields work correctly
- plugin-context: registerEditableFields permission guard and registry wiring
- install-context: assert legacyConfig absent from context
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* test: add Discord and Slack env var override tests for applyEnvToPluginSettings
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
- Added a new entry for 'testing' in tsup.config.ts to include src/testing.ts.
- Updated tsconfig.json in the plugin-sdk package to include a path mapping for '@openacp/cli/testing' pointing to the generated testing type definition.
- Menu titles now show context: "Choose session mode (current: Code)"
- Success messages: "Mode switched to **Architect**."
- Better errors: "This agent does not support switching modes."
- Already-set check: "Already using **Code**." (no redundant agent call)
- Bypass status: descriptive sentences with emojis
- Already-in-state check: "Bypass is already enabled/disabled."
- Client-side bypass explains why with italic note
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Args were off-by-one (args[2] instead of args[1]) after refactoring
the CLI dispatch. Also added help text for local directory install.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The TestPluginContext was missing the instanceRoot field added to
PluginContext in Task 7, causing build:publish to fail.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Combines setup wizard fixes (settingsManager/pluginRegistry passing,
ESM plugin resolution, path centralization) with develop's shell
injection validation and community adapter flow. Adds error handling
and tests for importFromDir.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Removed the Edge TTS provider implementation and its associated tests.
- Updated the SpeechService to support dynamic registration and unregistration of TTS providers.
- Enhanced the speech plugin to install the Edge TTS plugin dynamically if not already available.
- Adjusted configuration to exclude specific test directories and removed unnecessary dependencies from package.json.
* fix(api): respect channel param in POST /api/sessions (#76)
Session creation always used the first registered adapter. Add optional
`channel` field so callers can target a specific platform (e.g. discord).
Falls back to first-adapter behavior when omitted for backward compat.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix(api): wire --channel flag in CLI and assistant prompts (#76)
The API endpoint accepted `channel` but the CLI `openacp api new` didn't
pass it through. Add --channel flag to CLI and update Discord/Telegram
assistant prompts to include --channel so sessions are created on the
correct platform.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 27c1f141d0c1
* docs: add session cleanup feature design spec
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 8de760ac911e
* docs: address spec review feedback for session cleanup
- Reference existing TopicManager and archiveSession() instead of reimplementing
- Add parseDuration utility for --older-than flag
- Fix API route collision (/api/cleanup/ instead of /api/sessions/cleanable)
- Add CleanupFlowState for Telegram selection state with TTL
- Clarify default filter excludes active/initializing
- Add archiving flag edge case to test plan
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 98610f1a27c8
* docs: add design spec for extracting Discord plugin to standalone package
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 10f437186acf
* docs: address spec review feedback for Discord plugin extraction
- Fix npm scope to @openacp (not @open-acp) for consistency
- Fix peerDependency version to match date-based versioning
- Move misclassified exports to "Need to add" section
- Add ConfigManager, AgentCatalog, requestRestart to SDK exports list
- Add essential: false, pluginDependencies notes
- Add tsconfig.json template
- Add exports field and .npmignore to package.json
- Add runAdapterConformanceTests to SDK testing exports
- Add legacy migration map update for backward compat
- Add boot order note for pluginDependencies
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: c5db89eae6aa
* docs: add implementation plan for extracting Discord plugin
9 tasks: extend CLI exports, extend SDK, migration map, scaffold
project, copy+refactor source, verify build, remove from OpenACP,
update README, push repos.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: a54a5510736a
* feat(core): export format-utils, message-formatter, CommandRegistry, Doctor, PRODUCT_GUIDE for plugin SDK
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 27b04551e9a7
* feat(plugin-sdk): export all symbols needed by adapter plugins
Entire-Checkpoint: a1ed33612eb6
* fix(plugin): add @openacp/plugin-discord migration alias for backward compat
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: a9db7beb2975
* fix(sdk): add missing adapter-primitive exports and testing entry point
- Add MessagingAdapterConfig, IRenderer, RenderedMessage type exports to src/core/index.ts
- Add DisplayVerbosity, ToolCallMeta, ToolUpdateMeta, ViewerLinks type exports
- Add STATUS_ICONS, KIND_ICONS, progressBar, formatTokens, truncateContent, stripCodeFences, splitMessage exports
- Add extractContentText, formatToolSummary, formatToolTitle, resolveToolIcon exports
- Create src/testing.ts as a separate entry point exporting runAdapterConformanceTests
- Add ./testing export map to @openacp/cli package.json
- Fix @openacp/plugin-sdk/testing.ts to import from @openacp/cli/testing
- Fix version strings to use valid semver (2026.326.4 not 2026.0326.4)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix: restore original version format YYYY.MMDD.patch
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* feat: remove built-in Discord plugin (now available as @openacp/plugin-discord)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix(plugin): resolve 3 bugs preventing dev plugins from loading
- lifecycle-manager: include already-loaded plugins in dependency resolution
so late-booted dev plugins aren't cascade-skipped
- dev-loader: use URL query string for ESM cache busting instead of copying
to temp dir, which broke relative imports (e.g., './adapter.js')
- adapter-primitives: remove runAdapterConformanceTests from main barrel
to prevent vitest from leaking into runtime bundle
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 64f604573bb7
* fix(review): address PR #80 code review feedback
- Remove core→plugin-discord import in config-editor (architecture violation):
inline Discord token validation using REST API /users/@me instead of
importing from @openacp/plugin-discord/validators
- Mark legacyMap in lifecycle-manager as @deprecated with migration notes
- Remove 98 planning artifacts from docs/superpowers/ (72k+ lines)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: cdeeaa98a4f1
* Revert "fix(plugin): resolve 3 bugs preventing dev plugins from loading"
This reverts commit 031464640560628dd8c093a4d8d30895c775ef98.
Entire-Checkpoint: 6ed1a02a0cb5
* Reapply "fix(plugin): resolve 3 bugs preventing dev plugins from loading"
This reverts commit 5707bf1c240f52baab277d21333cd7d92c191fac.
Entire-Checkpoint: bfaaa263a765
* revert: restore docs/superpowers/ plans and specs
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 9195220e9172
* fix(review): revert unrelated changes and organize SDK sub-paths
- Revert --channel flag, assistant prompt changes, and session route
changes that don't belong in Discord extraction PR (#82)
- Add SDK sub-path exports: @openacp/plugin-sdk/formatting,
@openacp/plugin-sdk/config (alongside existing /testing) (#83)
- Mark SDK exports as @stable vs @experimental
- Fix plugin count test (10 → 9 after Discord removal)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 9bd5c44d98c4
* fix(review): address round 2 feedback on PR #80
- Rename @openacp/plugin-discord → @openacp/adapter-discord in all refs
(setup-channels, wizard, lifecycle-manager, docs)
- Keep @openacp/plugin-discord as legacy alias in lifecycle-manager
- Remove unrelated session-cleanup-design.md spec from PR
- SDK: deduplicate main barrel by re-exporting from sub-path modules
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 4454289e400f
* fix(review): remove remaining Discord references from core
- Remove Discord doctor check from core (plugin registers its own)
- Dynamic adapter discovery via ServiceRegistry instead of hardcoded list
- Remove @openacp/discord from auto-register built-in plugins list
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: c15c5fbf08c8
* fix(config): auto-install Discord plugin when enabling via config editor
When user enables or configures Discord through `openacp config` (not
onboarding), check if @openacp/adapter-discord is installed. If not,
prompt to install it automatically via npm.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: dd218c585ae3
* fix(review): round 3 cleanup — extensible ChannelId, update CLAUDE.md
- Change ChannelId from fixed union to string for extensibility
- Remove discord/ from CLAUDE.md project layout (now external plugin)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 66d8d185cda7
* fix(review): resolve all remaining Discord coupling in core
- Remove DiscordPlatformData from core types (plugin defines its own)
- Remove DiscordPlatformData from SDK re-exports
- Config editor: delegate Discord config to plugin configure() instead
of 100+ lines of inline Discord logic
- Update integrate.ts help text to be adapter-agnostic
- Clean absolute local paths from planning docs
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 094cc484aaae
* fix: replace execSync npm install with async utility
Extract installNpmPlugin() into a shared utility that uses async exec
instead of execSync, preventing event loop blocking. Used by both
config-editor.ts and wizard.ts instead of inline execSync calls.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: replace execSync with async installNpmPlugin utility
Extract shared plugin install logic into plugin-installer.ts using
promisify(exec) to avoid blocking the event loop during npm install.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 09c3d8b93ec9
* fix: pass settingsManager and pluginRegistry to setup wizard from CLI commands
cmdDefault and cmdOnboard called runSetup() without the required
settingsManager/pluginRegistry opts, causing "Plugin system not
initialized" error on first-run setup. Now both paths create these
dependencies before invoking the wizard, matching main.ts behavior.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 4cb5e64819c9
* fix: resolve npm plugins from plugins dir instead of project root
import(packageName) resolves from the project root, not from the
~/.openacp/plugins/node_modules where npm packages are actually
installed. Use createRequire + pathToFileURL to resolve from the
correct directory.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: e3f8576e9f51
* fix: resolve ESM-only npm plugins by reading package.json exports
createRequire cannot resolve packages that only define ESM exports
(no "require" condition). Instead, read the package's package.json
to find the entry point (exports["."].import > main > index.js)
and import by file URL.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 512775b194fb
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: 0xmrpeter <0xmrpeter@gmail.com>
Resolves conflicts in plugin-sdk exports and core index files.
Upstream extracted Discord to standalone package and refined SDK exports.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 385aad6258f7