Raven-1/tests/_browser_cache.py

168 lines
6.2 KiB
Python
Raw Permalink Normal View History

fix(*): key browser grants on the page a call lands on and prune owner state (#839) ## Summary Fixes the three defects #600 reports in the browser tools, and the test fixture that failed six real-browser tests on Linux. **A permission key could name a site the call would not act on.** The acting tools write the site into the call before the gate reads it, and took it from `url_for(owner)`, which fell back to the front tab for an owner with no live binding. When another owner held that tab, the call opened a blank tab of its own instead: a person approved `bank.test` for a key press that landed on `about:blank`, and banked a grant that any later click, type or press on `bank.test` presents, since the three verbs share one key per site. `url_for` now reports the page `_page_for` will bind, through one rule both use (`_landing`): the owner's live tab, else the front tab unless another live owner holds it, else nothing. In the last case the call opens a tab of its own, which no site describes yet, so no site is written and the grant is keyed on the call itself. The issue offered two directions, and neither is taken as written. An empty answer for every unbound owner fixes the reported case but breaks one that worked: with the front tab the reader's own, the call lands on it while the prompt names no site, and its per-call grant can then be presented by an identical call on whatever front tab comes next. Resolving the site after binding would make `cast_params` asynchronous, and that hook is part of the contract every tool shares. **`_BrowserTool._acted` was never pruned.** Keyed by `run:<uid>`, it kept one entry per delegated run for the life of the process: 50,000 runs left 50,000 entries and 6.6 MiB after `gc.collect()`. The driver now ends every binding through one `_drop_owners` (a reap, a release, the owner's tab closing, the browser closing) and tells a listener the tools register on their first stamp. The map also keeps only the 512 owners that acted most recently, for owners whose binding is never dropped. The same 50,000 runs now leave 512 entries. **`browser_tabs` did not say that close refuses a tab nobody holds.** Such a tab is the user's and may hold a login they were asked to finish, and the listing marks it neither `yours` nor `held`. The description now says so, as does the browser guide in both languages. **`test_browser_real_web.py` aimed Playwright at the macOS cache on every platform.** The suite redirects `HOME`, and Playwright resolves its cache from the home directory, so the fixture points it back at the login's cache, but only at `~/Library/Caches`. The look-up now lives in `tests/_browser_cache.py`, shared by both real-browser suites, and mirrors playwright-core's `registryDirectory`: XDG_CACHE_HOME on Linux, LOCALAPPDATA on Windows, `PLAYWRIGHT_BROWSERS_PATH=0` for an install inside the package, and a relative path. Both suites skipped only when the package was missing, so a missing browser failed them; they now check for the browser. The driver called that failure "not installed" even when the browser sat where the process did not look; the message now quotes the path it looked for and names PLAYWRIGHT_BROWSERS_PATH, on one line. Known gaps, left as they are: - `url_for` is a prediction made before the prompt. Anything that moves while a person decides (the reader switches tabs, another owner takes the front tab, the binding idles past ten minutes) moves the call with it. Closing that needs the gate to see the binding the call will use; the issue thread sketches one shape. - The skip checks for a Chromium directory, not the revision this Playwright needs. A cache holding only an older build still fails the launch, and the message then names the path it looked for. - `browser_tabs` stamps an owner after closing that owner's own tab; that stamp leaves through the cap rather than through a release. ## Type - [x] Fix - [ ] Feature - [ ] Docs - [ ] CI / tooling - [ ] Refactor - [ ] Other ## Verification Run with the project environment's interpreter (all extras installed): - `python -m pytest` over `tests/test_browser_cache.py`, `tests/test_browser_driver.py`, `tests/test_browser_tools.py`, `tests/test_browser_policy.py`, `tests/integration/test_browser_real_web.py` and `tests/integration/test_browser_tools_real_web.py`: 172 passed. CI does not collect `tests/integration/`, so those two files ran here only. With PLAYWRIGHT_BROWSERS_PATH pointed at a directory that does not exist, all 12 skip with the new reason instead of failing. - The `url_for` table, one case per branch of the landing rule, fails against main in the two cases where another owner holds the front tab, and against the empty-answer direction in the three where the front tab is free. - Deleting each of the 22 constructs that carry this change, one at a time, turns at least one test red. - `python -m pytest -q -p no:randomly`: 27132 passed, 7 failed, 116 skipped. The same 7 IDs fail on a complete tree of origin/main: five provider-proxy tests that read this machine's proxy settings, and two Node-runtime tests that depend on its node install and on root ignoring permission bits. - `ruff check` and `ruff format --check` on the changed files, `lint-imports` (10 kept, 0 broken), and `ty check raven evolver agents plugins-dist scripts` (the `make lint-types` set): all pass. - `scripts/check_source_language.py` and `scripts/check_large_files.py` over origin/main...HEAD, and `scripts/check_commit_messages.py` and commitlint over origin/main..HEAD: all pass. - [x] Relevant tests pass locally - [x] Relevant lint / type checks pass locally - [x] User-facing docs or screenshots are updated when needed ## Risk An acting call that would open a tab of its own is no longer keyed on the front tab's site: its prompt names no site, and a session grant for it covers only an identical call, so that state prompts more often. A call landing on the user's front tab keeps the site key it had. The browser-unavailable message the panel shows is reworded; nothing parses it. No config, schema or stored state changes, and reverting the squash commit restores the previous behaviour. - [x] Security impact considered - [x] Backward compatibility considered - [x] Rollback path is clear for risky changes ## Related Issues Fixes #600 --------- Co-authored-by: Claude (claude-opus-5-5[1m]) <noreply@anthropic.com>
2026-10-03 12:18:35 +08:00
"""Where Playwright keeps the Chromium a real-page test needs.
This suite redirects ``HOME`` at a per-test tmp dir (``tests/conftest.py``,
so no test reads the config of whoever is running it), and Playwright looks
its browsers up from the home directory -- so a real-page test has to aim the
look-up back at the login's own cache before it launches anything.
The rule mirrored here is ``registryDirectory`` in playwright-core's registry,
read from the driver bundled with playwright 1.62:
* ``PLAYWRIGHT_BROWSERS_PATH=0`` -- a hermetic install, inside the package;
* any other value of it -- that directory, a relative one taken from
``INIT_CWD`` or the working directory;
* otherwise ``ms-playwright`` under a per-OS cache root: ``XDG_CACHE_HOME``
or ``~/.cache`` on Linux, ``~/Library/Caches`` on macOS, ``LOCALAPPDATA`` or
``~/AppData/Local`` on Windows. Playwright refuses every other platform.
Only the home directory needs correcting: the two environment variables are
not sandboxed, so where one is set Playwright already finds the cache.
fix(*): keep the browser touch note, explain launch failures, isolate the test profile (#848) ## Summary Follow-ups to #839 in the browser driver, the browser tools and the real-browser tests. **The touch note survives the end of an owner's binding (regression from #839).** #839 had the driver tell the tools' `_acted` store whenever it dropped an owner's tab binding, and the store then deleted that owner's last-act stamp. The readback promises `note: the user interacted with the browser since your last action` until the owner acts again, and the end of a binding is not the end of the owner: `Browser.release()` has no production caller, so the listener fired only on a reap after `OWNER_IDLE_S`, on the owner's tab closing and on the browser closing. When the reader closed an agent's tab from the panel, or the binding idled out, the agent's next read lost the note. The listener is removed and the driver's owner removal is back to its pre-#839 form; `_ACTED_MAX` still bounds the store. **A host missing a system library is told so.** The driver now answers `Chromium is installed but cannot start here: the system library libatk-1.0.so.0 is missing. Installing system libraries needs root, so it is the user's step: on Debian or Ubuntu, <python> -m playwright install-deps chromium`. Before, on x64 the loader's refusal came back as Playwright's whole launch log, after a throwaway relaunch that could not help; where Playwright's own dependency check runs (its linux-arm64 Chromium builds), its report suggests `playwright install-deps`, which the driver read as "Chromium is not installed". The message says whose step it is because tool results reach the model too. **Only failures a fresh profile cannot fix skip the throwaway relaunch.** The relaunch was gated on the substring "profile", and every Playwright launch failure quotes the command line, `--user-data-dir=<home>/.raven/browser-profile` included, so every failure relaunched and logged "profile is busy". Every failure is still retried once except a missing system library, Playwright's host check and a missing executable, and the warning says the launch failed rather than that the profile is busy. Matching Chromium's lock words instead would be narrower and wrong under another locale: with `LANG=zh_CN.UTF-8` a second headful launch on a held profile prints its line in Chinese, Playwright's English rewrite of it does not fire, and the error says only "Target page, context or browser has been closed". **The profile path is read at launch.** `PROFILE_DIR` was computed at import, before `tests/conftest.py` gives each test its own HOME, so the real-browser tests used the developer's own `~/.raven/browser-profile`, with parallel workers opening it at once; the cookie `test_browser_real_web.py` sets turned up in a developer's own cookie jar. `_profile_dir()` now resolves the path on each launch. **The real-browser suites skip on a host that cannot load Chromium.** `tests/_browser_cache.py` gains `chromium_launch_failure()`: one bare headless launch per process, with Playwright alone. When it fails for a missing system library, both `tests/integration/test_browser_*real_web.py` modules skip with the library named: the twelve `libatk-1.0.so.0` launch failures reported on #839 become twelve skips. Any other launch failure, such as an older build left in the cache or a timeout under load, is not a reason to skip, and the suites fail on it as before. `docs/browser-and-desktop.md` said a second process would get a throwaway profile. The headless shell takes no profile lock, so a second headless Chromium opens the same profile; the sentence now says so. Not in this PR: - `url_for` still predicts the landing page before the permission prompt, so whatever moves while a person decides moves the call (the binding-generation idea in the #600 discussion). - Two headless Ravens share one profile with no lock; documented above, not changed. - `tests/integration/test_browser_tools_real_web.py::test_two_owners_two_tabs_and_neither_takes_the_other` hung in 2 of 73 runs of both real-browser files on main's tree -- both times with one profile shared by every worker, never in the 24 runs with a profile per test -- and in none of 78 runs on this branch or 240 runs of that test alone. The cause is unknown, and counts this small cannot credit any change here with a fix. One of the first 45 branch runs, made before the profile change, also failed one test outright; it was not seen again and is not explained. ## Type - [x] Fix - [ ] Feature - [ ] Docs - [ ] CI / tooling - [ ] Refactor - [ ] Other ## Verification Python 3.12, the repo environment with all extras, run from this tree. - `python -m pytest tests/test_browser_driver.py tests/test_browser_tools.py tests/test_browser_cache.py -q`: 129 passed. With `raven/browser/driver.py` and `raven/agent/tools/browser.py` taken from origin/main, 15 of them fail: the touch-note test for a reader's close and for an idle binding, the launch-time profile test, the four host-library cases, the empty-message retry, and the seven probe tests, which call a helper main lacks. - Each guarded construct was mutated on its own (14 mutations, among them: no stamp after a close, a stamp pruned on a tab close, each of the three no-retry clauses dropped, the host-library check moved after the not-installed one, the profile path fixed at import, the probe skipping on any failure, the probe launching on the caller's loop); each turns at least one test red. - Full suite, `python -m pytest -q`: 27482 passed, 116 skipped, 2 failed. Both failures are local to this box and touch nothing this branch changes: `tests/test_install_script.py::test_resolve_node_dir_answers_each_case_it_exists_for` (an npm elsewhere on PATH leaks past the fixture) and `tests/test_subagent_node_runtime.py::test_what_cannot_be_read_names_nothing` (the suite runs as root, which reads the file the test makes unreadable). - `python -m pytest tests/integration/test_browser_real_web.py tests/integration/test_browser_tools_real_web.py -q` with a real Chromium: 12 passed in each of 3 runs. A guard around `_profile_dir()` logged 39 resolutions, none under the real home, and no file under `~/.raven/browser-profile` changed during the runs. - Report shapes: the host-library fixtures follow real launches against a binary built to need an absent library, with Playwright's dependency check both skipped (the loader's refusal) and forced (both of its Linux reports). Two headless launches on one profile: the second starts. Two headful launches on one profile under `xvfb-run`: with `LANG=en_US.UTF-8` the error says the profile "is already in use"; with `LANG=zh_CN.UTF-8` it carries none of Chromium's English lock words. - `ruff check`, `ruff format --check`, `lint-imports` (10 kept), `ty check raven`, `scripts/check_source_language.py`, `scripts/check_large_files.py`: all pass. - [x] Relevant tests pass locally - [x] Relevant lint / type checks pass locally - [x] User-facing docs or screenshots are updated when needed ## Risk User-visible: the touch note is reported again after the reader closes an agent's tab or the binding idles out; a launch that fails for a missing system library reads as one line naming it, with no throwaway relaunch; every other launch failure still gets one throwaway relaunch, under a different warning. - [x] Security impact considered: the new message names a root command, and it is worded as the user's step because tool results reach the model. - [x] Backward compatibility considered: `Browser.on_owner_released` (added in #839) and the module constant `PROFILE_DIR` are removed; `git grep` finds no reader of either outside the two files changed here. - [x] Rollback path is clear for risky changes: revert the squash commit; nothing persisted changes shape. ## Related Issues Follows up #839; refs #600. --------- Co-authored-by: Claude (claude-opus-5-5[1m]) <noreply@anthropic.com>
2026-10-03 22:09:53 +08:00
A browser in the cache is not yet one this host can run -- a missing system
library stops it at launch -- so ``chromium_launch_failure`` starts one and
names the library it could not load.
fix(*): key browser grants on the page a call lands on and prune owner state (#839) ## Summary Fixes the three defects #600 reports in the browser tools, and the test fixture that failed six real-browser tests on Linux. **A permission key could name a site the call would not act on.** The acting tools write the site into the call before the gate reads it, and took it from `url_for(owner)`, which fell back to the front tab for an owner with no live binding. When another owner held that tab, the call opened a blank tab of its own instead: a person approved `bank.test` for a key press that landed on `about:blank`, and banked a grant that any later click, type or press on `bank.test` presents, since the three verbs share one key per site. `url_for` now reports the page `_page_for` will bind, through one rule both use (`_landing`): the owner's live tab, else the front tab unless another live owner holds it, else nothing. In the last case the call opens a tab of its own, which no site describes yet, so no site is written and the grant is keyed on the call itself. The issue offered two directions, and neither is taken as written. An empty answer for every unbound owner fixes the reported case but breaks one that worked: with the front tab the reader's own, the call lands on it while the prompt names no site, and its per-call grant can then be presented by an identical call on whatever front tab comes next. Resolving the site after binding would make `cast_params` asynchronous, and that hook is part of the contract every tool shares. **`_BrowserTool._acted` was never pruned.** Keyed by `run:<uid>`, it kept one entry per delegated run for the life of the process: 50,000 runs left 50,000 entries and 6.6 MiB after `gc.collect()`. The driver now ends every binding through one `_drop_owners` (a reap, a release, the owner's tab closing, the browser closing) and tells a listener the tools register on their first stamp. The map also keeps only the 512 owners that acted most recently, for owners whose binding is never dropped. The same 50,000 runs now leave 512 entries. **`browser_tabs` did not say that close refuses a tab nobody holds.** Such a tab is the user's and may hold a login they were asked to finish, and the listing marks it neither `yours` nor `held`. The description now says so, as does the browser guide in both languages. **`test_browser_real_web.py` aimed Playwright at the macOS cache on every platform.** The suite redirects `HOME`, and Playwright resolves its cache from the home directory, so the fixture points it back at the login's cache, but only at `~/Library/Caches`. The look-up now lives in `tests/_browser_cache.py`, shared by both real-browser suites, and mirrors playwright-core's `registryDirectory`: XDG_CACHE_HOME on Linux, LOCALAPPDATA on Windows, `PLAYWRIGHT_BROWSERS_PATH=0` for an install inside the package, and a relative path. Both suites skipped only when the package was missing, so a missing browser failed them; they now check for the browser. The driver called that failure "not installed" even when the browser sat where the process did not look; the message now quotes the path it looked for and names PLAYWRIGHT_BROWSERS_PATH, on one line. Known gaps, left as they are: - `url_for` is a prediction made before the prompt. Anything that moves while a person decides (the reader switches tabs, another owner takes the front tab, the binding idles past ten minutes) moves the call with it. Closing that needs the gate to see the binding the call will use; the issue thread sketches one shape. - The skip checks for a Chromium directory, not the revision this Playwright needs. A cache holding only an older build still fails the launch, and the message then names the path it looked for. - `browser_tabs` stamps an owner after closing that owner's own tab; that stamp leaves through the cap rather than through a release. ## Type - [x] Fix - [ ] Feature - [ ] Docs - [ ] CI / tooling - [ ] Refactor - [ ] Other ## Verification Run with the project environment's interpreter (all extras installed): - `python -m pytest` over `tests/test_browser_cache.py`, `tests/test_browser_driver.py`, `tests/test_browser_tools.py`, `tests/test_browser_policy.py`, `tests/integration/test_browser_real_web.py` and `tests/integration/test_browser_tools_real_web.py`: 172 passed. CI does not collect `tests/integration/`, so those two files ran here only. With PLAYWRIGHT_BROWSERS_PATH pointed at a directory that does not exist, all 12 skip with the new reason instead of failing. - The `url_for` table, one case per branch of the landing rule, fails against main in the two cases where another owner holds the front tab, and against the empty-answer direction in the three where the front tab is free. - Deleting each of the 22 constructs that carry this change, one at a time, turns at least one test red. - `python -m pytest -q -p no:randomly`: 27132 passed, 7 failed, 116 skipped. The same 7 IDs fail on a complete tree of origin/main: five provider-proxy tests that read this machine's proxy settings, and two Node-runtime tests that depend on its node install and on root ignoring permission bits. - `ruff check` and `ruff format --check` on the changed files, `lint-imports` (10 kept, 0 broken), and `ty check raven evolver agents plugins-dist scripts` (the `make lint-types` set): all pass. - `scripts/check_source_language.py` and `scripts/check_large_files.py` over origin/main...HEAD, and `scripts/check_commit_messages.py` and commitlint over origin/main..HEAD: all pass. - [x] Relevant tests pass locally - [x] Relevant lint / type checks pass locally - [x] User-facing docs or screenshots are updated when needed ## Risk An acting call that would open a tab of its own is no longer keyed on the front tab's site: its prompt names no site, and a session grant for it covers only an identical call, so that state prompts more often. A call landing on the user's front tab keeps the site key it had. The browser-unavailable message the panel shows is reworded; nothing parses it. No config, schema or stored state changes, and reverting the squash commit restores the previous behaviour. - [x] Security impact considered - [x] Backward compatibility considered - [x] Rollback path is clear for risky changes ## Related Issues Fixes #600 --------- Co-authored-by: Claude (claude-opus-5-5[1m]) <noreply@anthropic.com>
2026-10-03 12:18:35 +08:00
"""
from __future__ import annotations
fix(*): keep the browser touch note, explain launch failures, isolate the test profile (#848) ## Summary Follow-ups to #839 in the browser driver, the browser tools and the real-browser tests. **The touch note survives the end of an owner's binding (regression from #839).** #839 had the driver tell the tools' `_acted` store whenever it dropped an owner's tab binding, and the store then deleted that owner's last-act stamp. The readback promises `note: the user interacted with the browser since your last action` until the owner acts again, and the end of a binding is not the end of the owner: `Browser.release()` has no production caller, so the listener fired only on a reap after `OWNER_IDLE_S`, on the owner's tab closing and on the browser closing. When the reader closed an agent's tab from the panel, or the binding idled out, the agent's next read lost the note. The listener is removed and the driver's owner removal is back to its pre-#839 form; `_ACTED_MAX` still bounds the store. **A host missing a system library is told so.** The driver now answers `Chromium is installed but cannot start here: the system library libatk-1.0.so.0 is missing. Installing system libraries needs root, so it is the user's step: on Debian or Ubuntu, <python> -m playwright install-deps chromium`. Before, on x64 the loader's refusal came back as Playwright's whole launch log, after a throwaway relaunch that could not help; where Playwright's own dependency check runs (its linux-arm64 Chromium builds), its report suggests `playwright install-deps`, which the driver read as "Chromium is not installed". The message says whose step it is because tool results reach the model too. **Only failures a fresh profile cannot fix skip the throwaway relaunch.** The relaunch was gated on the substring "profile", and every Playwright launch failure quotes the command line, `--user-data-dir=<home>/.raven/browser-profile` included, so every failure relaunched and logged "profile is busy". Every failure is still retried once except a missing system library, Playwright's host check and a missing executable, and the warning says the launch failed rather than that the profile is busy. Matching Chromium's lock words instead would be narrower and wrong under another locale: with `LANG=zh_CN.UTF-8` a second headful launch on a held profile prints its line in Chinese, Playwright's English rewrite of it does not fire, and the error says only "Target page, context or browser has been closed". **The profile path is read at launch.** `PROFILE_DIR` was computed at import, before `tests/conftest.py` gives each test its own HOME, so the real-browser tests used the developer's own `~/.raven/browser-profile`, with parallel workers opening it at once; the cookie `test_browser_real_web.py` sets turned up in a developer's own cookie jar. `_profile_dir()` now resolves the path on each launch. **The real-browser suites skip on a host that cannot load Chromium.** `tests/_browser_cache.py` gains `chromium_launch_failure()`: one bare headless launch per process, with Playwright alone. When it fails for a missing system library, both `tests/integration/test_browser_*real_web.py` modules skip with the library named: the twelve `libatk-1.0.so.0` launch failures reported on #839 become twelve skips. Any other launch failure, such as an older build left in the cache or a timeout under load, is not a reason to skip, and the suites fail on it as before. `docs/browser-and-desktop.md` said a second process would get a throwaway profile. The headless shell takes no profile lock, so a second headless Chromium opens the same profile; the sentence now says so. Not in this PR: - `url_for` still predicts the landing page before the permission prompt, so whatever moves while a person decides moves the call (the binding-generation idea in the #600 discussion). - Two headless Ravens share one profile with no lock; documented above, not changed. - `tests/integration/test_browser_tools_real_web.py::test_two_owners_two_tabs_and_neither_takes_the_other` hung in 2 of 73 runs of both real-browser files on main's tree -- both times with one profile shared by every worker, never in the 24 runs with a profile per test -- and in none of 78 runs on this branch or 240 runs of that test alone. The cause is unknown, and counts this small cannot credit any change here with a fix. One of the first 45 branch runs, made before the profile change, also failed one test outright; it was not seen again and is not explained. ## Type - [x] Fix - [ ] Feature - [ ] Docs - [ ] CI / tooling - [ ] Refactor - [ ] Other ## Verification Python 3.12, the repo environment with all extras, run from this tree. - `python -m pytest tests/test_browser_driver.py tests/test_browser_tools.py tests/test_browser_cache.py -q`: 129 passed. With `raven/browser/driver.py` and `raven/agent/tools/browser.py` taken from origin/main, 15 of them fail: the touch-note test for a reader's close and for an idle binding, the launch-time profile test, the four host-library cases, the empty-message retry, and the seven probe tests, which call a helper main lacks. - Each guarded construct was mutated on its own (14 mutations, among them: no stamp after a close, a stamp pruned on a tab close, each of the three no-retry clauses dropped, the host-library check moved after the not-installed one, the profile path fixed at import, the probe skipping on any failure, the probe launching on the caller's loop); each turns at least one test red. - Full suite, `python -m pytest -q`: 27482 passed, 116 skipped, 2 failed. Both failures are local to this box and touch nothing this branch changes: `tests/test_install_script.py::test_resolve_node_dir_answers_each_case_it_exists_for` (an npm elsewhere on PATH leaks past the fixture) and `tests/test_subagent_node_runtime.py::test_what_cannot_be_read_names_nothing` (the suite runs as root, which reads the file the test makes unreadable). - `python -m pytest tests/integration/test_browser_real_web.py tests/integration/test_browser_tools_real_web.py -q` with a real Chromium: 12 passed in each of 3 runs. A guard around `_profile_dir()` logged 39 resolutions, none under the real home, and no file under `~/.raven/browser-profile` changed during the runs. - Report shapes: the host-library fixtures follow real launches against a binary built to need an absent library, with Playwright's dependency check both skipped (the loader's refusal) and forced (both of its Linux reports). Two headless launches on one profile: the second starts. Two headful launches on one profile under `xvfb-run`: with `LANG=en_US.UTF-8` the error says the profile "is already in use"; with `LANG=zh_CN.UTF-8` it carries none of Chromium's English lock words. - `ruff check`, `ruff format --check`, `lint-imports` (10 kept), `ty check raven`, `scripts/check_source_language.py`, `scripts/check_large_files.py`: all pass. - [x] Relevant tests pass locally - [x] Relevant lint / type checks pass locally - [x] User-facing docs or screenshots are updated when needed ## Risk User-visible: the touch note is reported again after the reader closes an agent's tab or the binding idles out; a launch that fails for a missing system library reads as one line naming it, with no throwaway relaunch; every other launch failure still gets one throwaway relaunch, under a different warning. - [x] Security impact considered: the new message names a root command, and it is worded as the user's step because tool results reach the model. - [x] Backward compatibility considered: `Browser.on_owner_released` (added in #839) and the module constant `PROFILE_DIR` are removed; `git grep` finds no reader of either outside the two files changed here. - [x] Rollback path is clear for risky changes: revert the squash commit; nothing persisted changes shape. ## Related Issues Follows up #839; refs #600. --------- Co-authored-by: Claude (claude-opus-5-5[1m]) <noreply@anthropic.com>
2026-10-03 22:09:53 +08:00
import asyncio
import concurrent.futures
import functools
fix(*): key browser grants on the page a call lands on and prune owner state (#839) ## Summary Fixes the three defects #600 reports in the browser tools, and the test fixture that failed six real-browser tests on Linux. **A permission key could name a site the call would not act on.** The acting tools write the site into the call before the gate reads it, and took it from `url_for(owner)`, which fell back to the front tab for an owner with no live binding. When another owner held that tab, the call opened a blank tab of its own instead: a person approved `bank.test` for a key press that landed on `about:blank`, and banked a grant that any later click, type or press on `bank.test` presents, since the three verbs share one key per site. `url_for` now reports the page `_page_for` will bind, through one rule both use (`_landing`): the owner's live tab, else the front tab unless another live owner holds it, else nothing. In the last case the call opens a tab of its own, which no site describes yet, so no site is written and the grant is keyed on the call itself. The issue offered two directions, and neither is taken as written. An empty answer for every unbound owner fixes the reported case but breaks one that worked: with the front tab the reader's own, the call lands on it while the prompt names no site, and its per-call grant can then be presented by an identical call on whatever front tab comes next. Resolving the site after binding would make `cast_params` asynchronous, and that hook is part of the contract every tool shares. **`_BrowserTool._acted` was never pruned.** Keyed by `run:<uid>`, it kept one entry per delegated run for the life of the process: 50,000 runs left 50,000 entries and 6.6 MiB after `gc.collect()`. The driver now ends every binding through one `_drop_owners` (a reap, a release, the owner's tab closing, the browser closing) and tells a listener the tools register on their first stamp. The map also keeps only the 512 owners that acted most recently, for owners whose binding is never dropped. The same 50,000 runs now leave 512 entries. **`browser_tabs` did not say that close refuses a tab nobody holds.** Such a tab is the user's and may hold a login they were asked to finish, and the listing marks it neither `yours` nor `held`. The description now says so, as does the browser guide in both languages. **`test_browser_real_web.py` aimed Playwright at the macOS cache on every platform.** The suite redirects `HOME`, and Playwright resolves its cache from the home directory, so the fixture points it back at the login's cache, but only at `~/Library/Caches`. The look-up now lives in `tests/_browser_cache.py`, shared by both real-browser suites, and mirrors playwright-core's `registryDirectory`: XDG_CACHE_HOME on Linux, LOCALAPPDATA on Windows, `PLAYWRIGHT_BROWSERS_PATH=0` for an install inside the package, and a relative path. Both suites skipped only when the package was missing, so a missing browser failed them; they now check for the browser. The driver called that failure "not installed" even when the browser sat where the process did not look; the message now quotes the path it looked for and names PLAYWRIGHT_BROWSERS_PATH, on one line. Known gaps, left as they are: - `url_for` is a prediction made before the prompt. Anything that moves while a person decides (the reader switches tabs, another owner takes the front tab, the binding idles past ten minutes) moves the call with it. Closing that needs the gate to see the binding the call will use; the issue thread sketches one shape. - The skip checks for a Chromium directory, not the revision this Playwright needs. A cache holding only an older build still fails the launch, and the message then names the path it looked for. - `browser_tabs` stamps an owner after closing that owner's own tab; that stamp leaves through the cap rather than through a release. ## Type - [x] Fix - [ ] Feature - [ ] Docs - [ ] CI / tooling - [ ] Refactor - [ ] Other ## Verification Run with the project environment's interpreter (all extras installed): - `python -m pytest` over `tests/test_browser_cache.py`, `tests/test_browser_driver.py`, `tests/test_browser_tools.py`, `tests/test_browser_policy.py`, `tests/integration/test_browser_real_web.py` and `tests/integration/test_browser_tools_real_web.py`: 172 passed. CI does not collect `tests/integration/`, so those two files ran here only. With PLAYWRIGHT_BROWSERS_PATH pointed at a directory that does not exist, all 12 skip with the new reason instead of failing. - The `url_for` table, one case per branch of the landing rule, fails against main in the two cases where another owner holds the front tab, and against the empty-answer direction in the three where the front tab is free. - Deleting each of the 22 constructs that carry this change, one at a time, turns at least one test red. - `python -m pytest -q -p no:randomly`: 27132 passed, 7 failed, 116 skipped. The same 7 IDs fail on a complete tree of origin/main: five provider-proxy tests that read this machine's proxy settings, and two Node-runtime tests that depend on its node install and on root ignoring permission bits. - `ruff check` and `ruff format --check` on the changed files, `lint-imports` (10 kept, 0 broken), and `ty check raven evolver agents plugins-dist scripts` (the `make lint-types` set): all pass. - `scripts/check_source_language.py` and `scripts/check_large_files.py` over origin/main...HEAD, and `scripts/check_commit_messages.py` and commitlint over origin/main..HEAD: all pass. - [x] Relevant tests pass locally - [x] Relevant lint / type checks pass locally - [x] User-facing docs or screenshots are updated when needed ## Risk An acting call that would open a tab of its own is no longer keyed on the front tab's site: its prompt names no site, and a session grant for it covers only an identical call, so that state prompts more often. A call landing on the user's front tab keeps the site key it had. The browser-unavailable message the panel shows is reworded; nothing parses it. No config, schema or stored state changes, and reverting the squash commit restores the previous behaviour. - [x] Security impact considered - [x] Backward compatibility considered - [x] Rollback path is clear for risky changes ## Related Issues Fixes #600 --------- Co-authored-by: Claude (claude-opus-5-5[1m]) <noreply@anthropic.com>
2026-10-03 12:18:35 +08:00
import os
import sys
try:
import pwd
except ImportError: # pragma: no cover - Windows has no pwd module
pwd = None # type: ignore[assignment]
def login_home() -> str:
"""The login directory, ignoring a ``HOME`` a fixture has sandboxed.
``pwd`` rather than ``Path.home()``, which follows ``HOME`` -- the value
every caller here is trying to see past. Without a passwd entry there is
nothing to see past it with, and ``HOME`` is the answer.
"""
if pwd is not None:
try:
return pwd.getpwuid(os.getuid()).pw_dir
except KeyError:
pass
return os.path.expanduser("~")
def playwright_cache(home: str) -> str | None:
"""The default browser cache for ``home``, or None where Playwright has none."""
if sys.platform == "linux":
root = os.environ.get("XDG_CACHE_HOME") or os.path.join(home, ".cache")
elif sys.platform == "darwin":
root = os.path.join(home, "Library", "Caches")
elif sys.platform == "win32":
root = os.environ.get("LOCALAPPDATA") or os.path.join(home, "AppData", "Local")
else:
return None
return os.path.join(root, "ms-playwright")
def browsers_dir() -> str | None:
"""The browser cache this process resolves to. Safe to call at import."""
explicit = os.environ.get("PLAYWRIGHT_BROWSERS_PATH")
if explicit == "0":
try:
import playwright
except ImportError:
return None
return os.path.join(os.path.dirname(playwright.__file__), "driver", "package", ".local-browsers")
if explicit:
return os.path.abspath(os.path.join(os.environ.get("INIT_CWD") or os.getcwd(), explicit))
return playwright_cache(login_home())
def chromium_installed(where: str | None = None) -> bool:
"""Whether a Chromium build sits in the browser cache.
A directory entry rather than ``Browser.probe()``, which only answers
whether the ``playwright`` package imports: skipping on the package alone
turned a missing binary into failures. It does not check the revision
-- a cache holding only an older build still fails the launch, loudly, and
the driver's error then names the path it looked for.
"""
target = where or browsers_dir()
if target is None:
return False
try:
return any(name.startswith("chromium") for name in os.listdir(target))
except OSError:
return False
fix(*): keep the browser touch note, explain launch failures, isolate the test profile (#848) ## Summary Follow-ups to #839 in the browser driver, the browser tools and the real-browser tests. **The touch note survives the end of an owner's binding (regression from #839).** #839 had the driver tell the tools' `_acted` store whenever it dropped an owner's tab binding, and the store then deleted that owner's last-act stamp. The readback promises `note: the user interacted with the browser since your last action` until the owner acts again, and the end of a binding is not the end of the owner: `Browser.release()` has no production caller, so the listener fired only on a reap after `OWNER_IDLE_S`, on the owner's tab closing and on the browser closing. When the reader closed an agent's tab from the panel, or the binding idled out, the agent's next read lost the note. The listener is removed and the driver's owner removal is back to its pre-#839 form; `_ACTED_MAX` still bounds the store. **A host missing a system library is told so.** The driver now answers `Chromium is installed but cannot start here: the system library libatk-1.0.so.0 is missing. Installing system libraries needs root, so it is the user's step: on Debian or Ubuntu, <python> -m playwright install-deps chromium`. Before, on x64 the loader's refusal came back as Playwright's whole launch log, after a throwaway relaunch that could not help; where Playwright's own dependency check runs (its linux-arm64 Chromium builds), its report suggests `playwright install-deps`, which the driver read as "Chromium is not installed". The message says whose step it is because tool results reach the model too. **Only failures a fresh profile cannot fix skip the throwaway relaunch.** The relaunch was gated on the substring "profile", and every Playwright launch failure quotes the command line, `--user-data-dir=<home>/.raven/browser-profile` included, so every failure relaunched and logged "profile is busy". Every failure is still retried once except a missing system library, Playwright's host check and a missing executable, and the warning says the launch failed rather than that the profile is busy. Matching Chromium's lock words instead would be narrower and wrong under another locale: with `LANG=zh_CN.UTF-8` a second headful launch on a held profile prints its line in Chinese, Playwright's English rewrite of it does not fire, and the error says only "Target page, context or browser has been closed". **The profile path is read at launch.** `PROFILE_DIR` was computed at import, before `tests/conftest.py` gives each test its own HOME, so the real-browser tests used the developer's own `~/.raven/browser-profile`, with parallel workers opening it at once; the cookie `test_browser_real_web.py` sets turned up in a developer's own cookie jar. `_profile_dir()` now resolves the path on each launch. **The real-browser suites skip on a host that cannot load Chromium.** `tests/_browser_cache.py` gains `chromium_launch_failure()`: one bare headless launch per process, with Playwright alone. When it fails for a missing system library, both `tests/integration/test_browser_*real_web.py` modules skip with the library named: the twelve `libatk-1.0.so.0` launch failures reported on #839 become twelve skips. Any other launch failure, such as an older build left in the cache or a timeout under load, is not a reason to skip, and the suites fail on it as before. `docs/browser-and-desktop.md` said a second process would get a throwaway profile. The headless shell takes no profile lock, so a second headless Chromium opens the same profile; the sentence now says so. Not in this PR: - `url_for` still predicts the landing page before the permission prompt, so whatever moves while a person decides moves the call (the binding-generation idea in the #600 discussion). - Two headless Ravens share one profile with no lock; documented above, not changed. - `tests/integration/test_browser_tools_real_web.py::test_two_owners_two_tabs_and_neither_takes_the_other` hung in 2 of 73 runs of both real-browser files on main's tree -- both times with one profile shared by every worker, never in the 24 runs with a profile per test -- and in none of 78 runs on this branch or 240 runs of that test alone. The cause is unknown, and counts this small cannot credit any change here with a fix. One of the first 45 branch runs, made before the profile change, also failed one test outright; it was not seen again and is not explained. ## Type - [x] Fix - [ ] Feature - [ ] Docs - [ ] CI / tooling - [ ] Refactor - [ ] Other ## Verification Python 3.12, the repo environment with all extras, run from this tree. - `python -m pytest tests/test_browser_driver.py tests/test_browser_tools.py tests/test_browser_cache.py -q`: 129 passed. With `raven/browser/driver.py` and `raven/agent/tools/browser.py` taken from origin/main, 15 of them fail: the touch-note test for a reader's close and for an idle binding, the launch-time profile test, the four host-library cases, the empty-message retry, and the seven probe tests, which call a helper main lacks. - Each guarded construct was mutated on its own (14 mutations, among them: no stamp after a close, a stamp pruned on a tab close, each of the three no-retry clauses dropped, the host-library check moved after the not-installed one, the profile path fixed at import, the probe skipping on any failure, the probe launching on the caller's loop); each turns at least one test red. - Full suite, `python -m pytest -q`: 27482 passed, 116 skipped, 2 failed. Both failures are local to this box and touch nothing this branch changes: `tests/test_install_script.py::test_resolve_node_dir_answers_each_case_it_exists_for` (an npm elsewhere on PATH leaks past the fixture) and `tests/test_subagent_node_runtime.py::test_what_cannot_be_read_names_nothing` (the suite runs as root, which reads the file the test makes unreadable). - `python -m pytest tests/integration/test_browser_real_web.py tests/integration/test_browser_tools_real_web.py -q` with a real Chromium: 12 passed in each of 3 runs. A guard around `_profile_dir()` logged 39 resolutions, none under the real home, and no file under `~/.raven/browser-profile` changed during the runs. - Report shapes: the host-library fixtures follow real launches against a binary built to need an absent library, with Playwright's dependency check both skipped (the loader's refusal) and forced (both of its Linux reports). Two headless launches on one profile: the second starts. Two headful launches on one profile under `xvfb-run`: with `LANG=en_US.UTF-8` the error says the profile "is already in use"; with `LANG=zh_CN.UTF-8` it carries none of Chromium's English lock words. - `ruff check`, `ruff format --check`, `lint-imports` (10 kept), `ty check raven`, `scripts/check_source_language.py`, `scripts/check_large_files.py`: all pass. - [x] Relevant tests pass locally - [x] Relevant lint / type checks pass locally - [x] User-facing docs or screenshots are updated when needed ## Risk User-visible: the touch note is reported again after the reader closes an agent's tab or the binding idles out; a launch that fails for a missing system library reads as one line naming it, with no throwaway relaunch; every other launch failure still gets one throwaway relaunch, under a different warning. - [x] Security impact considered: the new message names a root command, and it is worded as the user's step because tool results reach the model. - [x] Backward compatibility considered: `Browser.on_owner_released` (added in #839) and the module constant `PROFILE_DIR` are removed; `git grep` finds no reader of either outside the two files changed here. - [x] Rollback path is clear for risky changes: revert the squash commit; nothing persisted changes shape. ## Related Issues Follows up #839; refs #600. --------- Co-authored-by: Claude (claude-opus-5-5[1m]) <noreply@anthropic.com>
2026-10-03 22:09:53 +08:00
def _bare_launch() -> None:
"""Start and stop a headless Chromium with Playwright alone; raises on failure.
On a worker thread with a loop of its own, because a caller may already be
inside a running event loop, where ``asyncio.run`` refuses to start.
"""
from playwright.async_api import async_playwright
async def launch() -> None:
async with async_playwright() as pw:
browser = await pw.chromium.launch(headless=True)
await browser.close()
with concurrent.futures.ThreadPoolExecutor(max_workers=1) as pool:
pool.submit(lambda: asyncio.run(launch())).result()
@functools.cache
def chromium_launch_failure() -> str | None:
"""The system library this host lacks for a headless Chromium, or None.
A directory in the cache says a browser was downloaded, not that this host
can run it: one missing a system library it links against fails every test
at launch, and no change to the code under test can fix that. Any other
failure answers None, so the suites run and fail on it loudly -- an older
build left in the cache (see ``chromium_installed``) or a launch that
failed under load is not something this host lacks. Started with Playwright
alone, not through raven's driver, so what it finds is the host's by
construction. Asked once per process, since it costs a browser start, and
aimed at the cache the suites' own fixture will point at, because this runs
before that fixture does.
"""
from raven.browser.driver import _host_library_gap
target = browsers_dir()
if target is None:
return None
saved = os.environ.get("PLAYWRIGHT_BROWSERS_PATH")
os.environ["PLAYWRIGHT_BROWSERS_PATH"] = target
try:
_bare_launch()
except Exception as exc: # noqa: BLE001 - a host's lack is named, anything else is no reason to skip
return _host_library_gap(str(exc))
finally:
if saved is None:
os.environ.pop("PLAYWRIGHT_BROWSERS_PATH", None)
else:
os.environ["PLAYWRIGHT_BROWSERS_PATH"] = saved
return None
fix(*): key browser grants on the page a call lands on and prune owner state (#839) ## Summary Fixes the three defects #600 reports in the browser tools, and the test fixture that failed six real-browser tests on Linux. **A permission key could name a site the call would not act on.** The acting tools write the site into the call before the gate reads it, and took it from `url_for(owner)`, which fell back to the front tab for an owner with no live binding. When another owner held that tab, the call opened a blank tab of its own instead: a person approved `bank.test` for a key press that landed on `about:blank`, and banked a grant that any later click, type or press on `bank.test` presents, since the three verbs share one key per site. `url_for` now reports the page `_page_for` will bind, through one rule both use (`_landing`): the owner's live tab, else the front tab unless another live owner holds it, else nothing. In the last case the call opens a tab of its own, which no site describes yet, so no site is written and the grant is keyed on the call itself. The issue offered two directions, and neither is taken as written. An empty answer for every unbound owner fixes the reported case but breaks one that worked: with the front tab the reader's own, the call lands on it while the prompt names no site, and its per-call grant can then be presented by an identical call on whatever front tab comes next. Resolving the site after binding would make `cast_params` asynchronous, and that hook is part of the contract every tool shares. **`_BrowserTool._acted` was never pruned.** Keyed by `run:<uid>`, it kept one entry per delegated run for the life of the process: 50,000 runs left 50,000 entries and 6.6 MiB after `gc.collect()`. The driver now ends every binding through one `_drop_owners` (a reap, a release, the owner's tab closing, the browser closing) and tells a listener the tools register on their first stamp. The map also keeps only the 512 owners that acted most recently, for owners whose binding is never dropped. The same 50,000 runs now leave 512 entries. **`browser_tabs` did not say that close refuses a tab nobody holds.** Such a tab is the user's and may hold a login they were asked to finish, and the listing marks it neither `yours` nor `held`. The description now says so, as does the browser guide in both languages. **`test_browser_real_web.py` aimed Playwright at the macOS cache on every platform.** The suite redirects `HOME`, and Playwright resolves its cache from the home directory, so the fixture points it back at the login's cache, but only at `~/Library/Caches`. The look-up now lives in `tests/_browser_cache.py`, shared by both real-browser suites, and mirrors playwright-core's `registryDirectory`: XDG_CACHE_HOME on Linux, LOCALAPPDATA on Windows, `PLAYWRIGHT_BROWSERS_PATH=0` for an install inside the package, and a relative path. Both suites skipped only when the package was missing, so a missing browser failed them; they now check for the browser. The driver called that failure "not installed" even when the browser sat where the process did not look; the message now quotes the path it looked for and names PLAYWRIGHT_BROWSERS_PATH, on one line. Known gaps, left as they are: - `url_for` is a prediction made before the prompt. Anything that moves while a person decides (the reader switches tabs, another owner takes the front tab, the binding idles past ten minutes) moves the call with it. Closing that needs the gate to see the binding the call will use; the issue thread sketches one shape. - The skip checks for a Chromium directory, not the revision this Playwright needs. A cache holding only an older build still fails the launch, and the message then names the path it looked for. - `browser_tabs` stamps an owner after closing that owner's own tab; that stamp leaves through the cap rather than through a release. ## Type - [x] Fix - [ ] Feature - [ ] Docs - [ ] CI / tooling - [ ] Refactor - [ ] Other ## Verification Run with the project environment's interpreter (all extras installed): - `python -m pytest` over `tests/test_browser_cache.py`, `tests/test_browser_driver.py`, `tests/test_browser_tools.py`, `tests/test_browser_policy.py`, `tests/integration/test_browser_real_web.py` and `tests/integration/test_browser_tools_real_web.py`: 172 passed. CI does not collect `tests/integration/`, so those two files ran here only. With PLAYWRIGHT_BROWSERS_PATH pointed at a directory that does not exist, all 12 skip with the new reason instead of failing. - The `url_for` table, one case per branch of the landing rule, fails against main in the two cases where another owner holds the front tab, and against the empty-answer direction in the three where the front tab is free. - Deleting each of the 22 constructs that carry this change, one at a time, turns at least one test red. - `python -m pytest -q -p no:randomly`: 27132 passed, 7 failed, 116 skipped. The same 7 IDs fail on a complete tree of origin/main: five provider-proxy tests that read this machine's proxy settings, and two Node-runtime tests that depend on its node install and on root ignoring permission bits. - `ruff check` and `ruff format --check` on the changed files, `lint-imports` (10 kept, 0 broken), and `ty check raven evolver agents plugins-dist scripts` (the `make lint-types` set): all pass. - `scripts/check_source_language.py` and `scripts/check_large_files.py` over origin/main...HEAD, and `scripts/check_commit_messages.py` and commitlint over origin/main..HEAD: all pass. - [x] Relevant tests pass locally - [x] Relevant lint / type checks pass locally - [x] User-facing docs or screenshots are updated when needed ## Risk An acting call that would open a tab of its own is no longer keyed on the front tab's site: its prompt names no site, and a session grant for it covers only an identical call, so that state prompts more often. A call landing on the user's front tab keeps the site key it had. The browser-unavailable message the panel shows is reworded; nothing parses it. No config, schema or stored state changes, and reverting the squash commit restores the previous behaviour. - [x] Security impact considered - [x] Backward compatibility considered - [x] Rollback path is clear for risky changes ## Related Issues Fixes #600 --------- Co-authored-by: Claude (claude-opus-5-5[1m]) <noreply@anthropic.com>
2026-10-03 12:18:35 +08:00
def point_at_login_cache(monkeypatch) -> None:
"""Fixture body: aim Playwright at the login's cache, unless already aimed."""
if os.environ.get("PLAYWRIGHT_BROWSERS_PATH"):
return
cache = playwright_cache(login_home())
if cache is not None:
monkeypatch.setenv("PLAYWRIGHT_BROWSERS_PATH", cache)
__all__ = [
"browsers_dir",
"chromium_installed",
fix(*): keep the browser touch note, explain launch failures, isolate the test profile (#848) ## Summary Follow-ups to #839 in the browser driver, the browser tools and the real-browser tests. **The touch note survives the end of an owner's binding (regression from #839).** #839 had the driver tell the tools' `_acted` store whenever it dropped an owner's tab binding, and the store then deleted that owner's last-act stamp. The readback promises `note: the user interacted with the browser since your last action` until the owner acts again, and the end of a binding is not the end of the owner: `Browser.release()` has no production caller, so the listener fired only on a reap after `OWNER_IDLE_S`, on the owner's tab closing and on the browser closing. When the reader closed an agent's tab from the panel, or the binding idled out, the agent's next read lost the note. The listener is removed and the driver's owner removal is back to its pre-#839 form; `_ACTED_MAX` still bounds the store. **A host missing a system library is told so.** The driver now answers `Chromium is installed but cannot start here: the system library libatk-1.0.so.0 is missing. Installing system libraries needs root, so it is the user's step: on Debian or Ubuntu, <python> -m playwright install-deps chromium`. Before, on x64 the loader's refusal came back as Playwright's whole launch log, after a throwaway relaunch that could not help; where Playwright's own dependency check runs (its linux-arm64 Chromium builds), its report suggests `playwright install-deps`, which the driver read as "Chromium is not installed". The message says whose step it is because tool results reach the model too. **Only failures a fresh profile cannot fix skip the throwaway relaunch.** The relaunch was gated on the substring "profile", and every Playwright launch failure quotes the command line, `--user-data-dir=<home>/.raven/browser-profile` included, so every failure relaunched and logged "profile is busy". Every failure is still retried once except a missing system library, Playwright's host check and a missing executable, and the warning says the launch failed rather than that the profile is busy. Matching Chromium's lock words instead would be narrower and wrong under another locale: with `LANG=zh_CN.UTF-8` a second headful launch on a held profile prints its line in Chinese, Playwright's English rewrite of it does not fire, and the error says only "Target page, context or browser has been closed". **The profile path is read at launch.** `PROFILE_DIR` was computed at import, before `tests/conftest.py` gives each test its own HOME, so the real-browser tests used the developer's own `~/.raven/browser-profile`, with parallel workers opening it at once; the cookie `test_browser_real_web.py` sets turned up in a developer's own cookie jar. `_profile_dir()` now resolves the path on each launch. **The real-browser suites skip on a host that cannot load Chromium.** `tests/_browser_cache.py` gains `chromium_launch_failure()`: one bare headless launch per process, with Playwright alone. When it fails for a missing system library, both `tests/integration/test_browser_*real_web.py` modules skip with the library named: the twelve `libatk-1.0.so.0` launch failures reported on #839 become twelve skips. Any other launch failure, such as an older build left in the cache or a timeout under load, is not a reason to skip, and the suites fail on it as before. `docs/browser-and-desktop.md` said a second process would get a throwaway profile. The headless shell takes no profile lock, so a second headless Chromium opens the same profile; the sentence now says so. Not in this PR: - `url_for` still predicts the landing page before the permission prompt, so whatever moves while a person decides moves the call (the binding-generation idea in the #600 discussion). - Two headless Ravens share one profile with no lock; documented above, not changed. - `tests/integration/test_browser_tools_real_web.py::test_two_owners_two_tabs_and_neither_takes_the_other` hung in 2 of 73 runs of both real-browser files on main's tree -- both times with one profile shared by every worker, never in the 24 runs with a profile per test -- and in none of 78 runs on this branch or 240 runs of that test alone. The cause is unknown, and counts this small cannot credit any change here with a fix. One of the first 45 branch runs, made before the profile change, also failed one test outright; it was not seen again and is not explained. ## Type - [x] Fix - [ ] Feature - [ ] Docs - [ ] CI / tooling - [ ] Refactor - [ ] Other ## Verification Python 3.12, the repo environment with all extras, run from this tree. - `python -m pytest tests/test_browser_driver.py tests/test_browser_tools.py tests/test_browser_cache.py -q`: 129 passed. With `raven/browser/driver.py` and `raven/agent/tools/browser.py` taken from origin/main, 15 of them fail: the touch-note test for a reader's close and for an idle binding, the launch-time profile test, the four host-library cases, the empty-message retry, and the seven probe tests, which call a helper main lacks. - Each guarded construct was mutated on its own (14 mutations, among them: no stamp after a close, a stamp pruned on a tab close, each of the three no-retry clauses dropped, the host-library check moved after the not-installed one, the profile path fixed at import, the probe skipping on any failure, the probe launching on the caller's loop); each turns at least one test red. - Full suite, `python -m pytest -q`: 27482 passed, 116 skipped, 2 failed. Both failures are local to this box and touch nothing this branch changes: `tests/test_install_script.py::test_resolve_node_dir_answers_each_case_it_exists_for` (an npm elsewhere on PATH leaks past the fixture) and `tests/test_subagent_node_runtime.py::test_what_cannot_be_read_names_nothing` (the suite runs as root, which reads the file the test makes unreadable). - `python -m pytest tests/integration/test_browser_real_web.py tests/integration/test_browser_tools_real_web.py -q` with a real Chromium: 12 passed in each of 3 runs. A guard around `_profile_dir()` logged 39 resolutions, none under the real home, and no file under `~/.raven/browser-profile` changed during the runs. - Report shapes: the host-library fixtures follow real launches against a binary built to need an absent library, with Playwright's dependency check both skipped (the loader's refusal) and forced (both of its Linux reports). Two headless launches on one profile: the second starts. Two headful launches on one profile under `xvfb-run`: with `LANG=en_US.UTF-8` the error says the profile "is already in use"; with `LANG=zh_CN.UTF-8` it carries none of Chromium's English lock words. - `ruff check`, `ruff format --check`, `lint-imports` (10 kept), `ty check raven`, `scripts/check_source_language.py`, `scripts/check_large_files.py`: all pass. - [x] Relevant tests pass locally - [x] Relevant lint / type checks pass locally - [x] User-facing docs or screenshots are updated when needed ## Risk User-visible: the touch note is reported again after the reader closes an agent's tab or the binding idles out; a launch that fails for a missing system library reads as one line naming it, with no throwaway relaunch; every other launch failure still gets one throwaway relaunch, under a different warning. - [x] Security impact considered: the new message names a root command, and it is worded as the user's step because tool results reach the model. - [x] Backward compatibility considered: `Browser.on_owner_released` (added in #839) and the module constant `PROFILE_DIR` are removed; `git grep` finds no reader of either outside the two files changed here. - [x] Rollback path is clear for risky changes: revert the squash commit; nothing persisted changes shape. ## Related Issues Follows up #839; refs #600. --------- Co-authored-by: Claude (claude-opus-5-5[1m]) <noreply@anthropic.com>
2026-10-03 22:09:53 +08:00
"chromium_launch_failure",
fix(*): key browser grants on the page a call lands on and prune owner state (#839) ## Summary Fixes the three defects #600 reports in the browser tools, and the test fixture that failed six real-browser tests on Linux. **A permission key could name a site the call would not act on.** The acting tools write the site into the call before the gate reads it, and took it from `url_for(owner)`, which fell back to the front tab for an owner with no live binding. When another owner held that tab, the call opened a blank tab of its own instead: a person approved `bank.test` for a key press that landed on `about:blank`, and banked a grant that any later click, type or press on `bank.test` presents, since the three verbs share one key per site. `url_for` now reports the page `_page_for` will bind, through one rule both use (`_landing`): the owner's live tab, else the front tab unless another live owner holds it, else nothing. In the last case the call opens a tab of its own, which no site describes yet, so no site is written and the grant is keyed on the call itself. The issue offered two directions, and neither is taken as written. An empty answer for every unbound owner fixes the reported case but breaks one that worked: with the front tab the reader's own, the call lands on it while the prompt names no site, and its per-call grant can then be presented by an identical call on whatever front tab comes next. Resolving the site after binding would make `cast_params` asynchronous, and that hook is part of the contract every tool shares. **`_BrowserTool._acted` was never pruned.** Keyed by `run:<uid>`, it kept one entry per delegated run for the life of the process: 50,000 runs left 50,000 entries and 6.6 MiB after `gc.collect()`. The driver now ends every binding through one `_drop_owners` (a reap, a release, the owner's tab closing, the browser closing) and tells a listener the tools register on their first stamp. The map also keeps only the 512 owners that acted most recently, for owners whose binding is never dropped. The same 50,000 runs now leave 512 entries. **`browser_tabs` did not say that close refuses a tab nobody holds.** Such a tab is the user's and may hold a login they were asked to finish, and the listing marks it neither `yours` nor `held`. The description now says so, as does the browser guide in both languages. **`test_browser_real_web.py` aimed Playwright at the macOS cache on every platform.** The suite redirects `HOME`, and Playwright resolves its cache from the home directory, so the fixture points it back at the login's cache, but only at `~/Library/Caches`. The look-up now lives in `tests/_browser_cache.py`, shared by both real-browser suites, and mirrors playwright-core's `registryDirectory`: XDG_CACHE_HOME on Linux, LOCALAPPDATA on Windows, `PLAYWRIGHT_BROWSERS_PATH=0` for an install inside the package, and a relative path. Both suites skipped only when the package was missing, so a missing browser failed them; they now check for the browser. The driver called that failure "not installed" even when the browser sat where the process did not look; the message now quotes the path it looked for and names PLAYWRIGHT_BROWSERS_PATH, on one line. Known gaps, left as they are: - `url_for` is a prediction made before the prompt. Anything that moves while a person decides (the reader switches tabs, another owner takes the front tab, the binding idles past ten minutes) moves the call with it. Closing that needs the gate to see the binding the call will use; the issue thread sketches one shape. - The skip checks for a Chromium directory, not the revision this Playwright needs. A cache holding only an older build still fails the launch, and the message then names the path it looked for. - `browser_tabs` stamps an owner after closing that owner's own tab; that stamp leaves through the cap rather than through a release. ## Type - [x] Fix - [ ] Feature - [ ] Docs - [ ] CI / tooling - [ ] Refactor - [ ] Other ## Verification Run with the project environment's interpreter (all extras installed): - `python -m pytest` over `tests/test_browser_cache.py`, `tests/test_browser_driver.py`, `tests/test_browser_tools.py`, `tests/test_browser_policy.py`, `tests/integration/test_browser_real_web.py` and `tests/integration/test_browser_tools_real_web.py`: 172 passed. CI does not collect `tests/integration/`, so those two files ran here only. With PLAYWRIGHT_BROWSERS_PATH pointed at a directory that does not exist, all 12 skip with the new reason instead of failing. - The `url_for` table, one case per branch of the landing rule, fails against main in the two cases where another owner holds the front tab, and against the empty-answer direction in the three where the front tab is free. - Deleting each of the 22 constructs that carry this change, one at a time, turns at least one test red. - `python -m pytest -q -p no:randomly`: 27132 passed, 7 failed, 116 skipped. The same 7 IDs fail on a complete tree of origin/main: five provider-proxy tests that read this machine's proxy settings, and two Node-runtime tests that depend on its node install and on root ignoring permission bits. - `ruff check` and `ruff format --check` on the changed files, `lint-imports` (10 kept, 0 broken), and `ty check raven evolver agents plugins-dist scripts` (the `make lint-types` set): all pass. - `scripts/check_source_language.py` and `scripts/check_large_files.py` over origin/main...HEAD, and `scripts/check_commit_messages.py` and commitlint over origin/main..HEAD: all pass. - [x] Relevant tests pass locally - [x] Relevant lint / type checks pass locally - [x] User-facing docs or screenshots are updated when needed ## Risk An acting call that would open a tab of its own is no longer keyed on the front tab's site: its prompt names no site, and a session grant for it covers only an identical call, so that state prompts more often. A call landing on the user's front tab keeps the site key it had. The browser-unavailable message the panel shows is reworded; nothing parses it. No config, schema or stored state changes, and reverting the squash commit restores the previous behaviour. - [x] Security impact considered - [x] Backward compatibility considered - [x] Rollback path is clear for risky changes ## Related Issues Fixes #600 --------- Co-authored-by: Claude (claude-opus-5-5[1m]) <noreply@anthropic.com>
2026-10-03 12:18:35 +08:00
"login_home",
"playwright_cache",
"point_at_login_cache",
]