Raven-1/tests/test_backend_feedback_dispatch.py
Handsome-wzw 7b45527b5b fix(tools): an array sent as its own JSON is still an array
## Summary

Reported as "deliver_files is broken". It is not: **the tool never ran.**

Every `deliver_files` call on one install was refused before dispatch -- five in a row in a single session -- and nothing was ever delivered:

```
Error: Invalid parameters for tool 'deliver_files': files should be array
```

What the model sent was the array, spelled as a string:

```json
{"files": "[{\"path\": \"...poster.png\", \"title\": \"...\"}]", "message": "..."}
```

`cast_params` already forgives that spelling for every scalar type -- `"3"` for an integer, `"true"` for a boolean -- and did not for arrays or objects, which are exactly the types a model is most likely to stringify.

## Type

- [x] Fix
- [ ] Feature

## The edge of the forgiving is the design

When the value is a string, try `json.loads`, and take the result **only if it is the type the schema asked for**. A string that is not JSON, or is JSON of the wrong shape, is returned unchanged so the validator still names the real problem -- the point is to widen what is accepted, not to swallow a type error.

**Nothing here can raise.** Turning "your argument has the wrong type" into a traceback would be worse than the refusal it replaces, so the parse is wrapped and failure falls through.

**A `type: "string"` field is never parsed.** JSON is ordinary text in a message body or a file's content, and replacing it would hand the tool something it never asked for. Two independent things prevent it today (the string branch returns before the parse is reached, and the parse only wins on a type match), which is why the case pinning it is a tripwire rather than a load-bearing assertion -- said so in its own docstring rather than left to look like coverage.

## Not just deliver_files

Six built-in tools declare an array or object parameter and were all exposed:

| tool | parameter |
|---|---|
| `deliver_files` | `files` |
| `ask_user` | `questions` |
| `image_generate` | `images` |
| `message` | `media` |
| `create_playbook` | `skills` |
| `video_generate` | `params` |

The same failure was already seen from the other side: `acp_client/acp_agent.py` records `update_task_state` and `operations should be array` from a real dispatch.

## Verification

```
make lint-python    ruff check + ruff format --check, 1850 files
make lint-imports   9 contracts kept, 0 broken
pytest tests/       19,699 passed, 7 failed (all pre-existing, see below)
```

- [x] Relevant tests pass locally
- [x] Relevant lint / type checks pass locally
- [ ] User-facing docs or screenshots -- no user-facing string

**End to end, through the real tool**, with the exact payload that failed five times in production:

```
files sent as:            str -> [{"path": ".../poster.png", "title": "..."}]
returned:                 Delivered 1 file(s): poster.png (72 B).
still "should be array":  False
registered in the store:  True
```

Twelve cases, five mutations, each killing at least one:

| mutation | red |
|---|---|
| drop the whole branch (the old behaviour) | 3 |
| raise instead of falling through on a parse failure | 5 |
| accept the parse whatever type it yielded | 1 |
| do not re-cast the parsed value, so items are not cast | 1 |
| widen the tuple to include `string` | **survived -- unreachable** |

The last is worth stating rather than hiding: that mutation cannot change behaviour, because the `type == "string"` branch returns earlier and the type check would refuse the result anyway. I also tried moving the new block above that branch, alone and combined with widening the tuple, and neither reddens anything either. The invariant holds by construction; the case that documents it says so.

**Pre-existing failures, checked against the base.** 7 failed in the full run, all in `tests/test_security_network.py` (`test_a_redirect_to_a_dangerous_address_is_refused` and siblings). Running that file alone on this same tree gives 4 -- the count is order-dependent -- and the change touches only `raven/agent/tools/params.py` plus a new test file, neither of which `raven/security/network.py` imports. The failures are the box's resolver: it returns poisoned answers roughly half the time, which I measured separately (`en.wikipedia.org` came back as `2001::1` on 3 of 6 lookups). Not introduced here, and worth someone's attention on its own.

## Risk

- [x] Security impact considered -- widens what reaches a tool's own validation, not what bypasses it. A parsed value is still validated against the same schema, and a parse that yields the wrong type is refused exactly as before
- [x] Backward compatibility considered -- a call that worked before takes the identical path; the new branch is reached only by a `str` where an array or object is declared, which previously always failed
- [x] Rollback path is clear -- single-commit revert

## Related Issues

N/A

## Swept

`mr-review-patterns` pre-submit sweep, over `git diff origin/main...HEAD`.

- **1 (a write location moved)** -- nothing moved; a branch was added to an existing dispatch on `target_type`. Grepped every caller of `cast_params`: the registry is the only one, and it runs `validate_params` right after, which is the reader this affects.
- **2 (a value with several entry points)** -- the cast is the single funnel every tool argument passes through, which is why the fix belongs here and not in `deliver_files`.
- **3 (a guard)** -- checked both directions: what it wrongly lets through (JSON of the wrong type, non-JSON text -- both refused, with cases) and what it wrongly refuses (a real list, unaffected, with a case).
- **4 (tests)** -- five mutations above, one honestly reported as unreachable. Failing-ID sets diffed against the base rather than counts.
- **6 (stale text)** -- the module docstring enumerated what is coerced ("a string that should be an integer"); it now names arrays and objects too. Grepped the tracked tree for other statements of the rule: none.
- **9 (error handling)** -- the new path adds one way to end and it is caught: `json.loads` raises `ValueError` on bad text and `TypeError` on a non-string, and both fall through to the untouched value.
- **11** -- `git ls-files | grep -c node_modules` is 0; the commit-message gate was run, not eyeballed.

Not applicable, with reasons: **3b, 3c, 3d, 3e** (no tool schema produced, no state moved, one lane, no assertion lost its symbol); **4b, 4c, 4d** (no platform branch, no shell, no rendered number); **5, 5b** (no dependency; `json` is stdlib and already imported across this package); **6b, 6c** (no backup, no generated artifact); **7, 7b** (nothing on disk); **8** (no asset, no secret); **10** (no prompt text).

## Deliberately not fixed

The error text still ends with `[Analyze the error above and try a different approach.]`, and the model plainly did not -- it sent the same shape five times. A message naming the expected spelling (`files must be a JSON array, not a string containing one`) would give it something to act on. That is a change to the registry's error surface, affects every tool, and deserves its own argument.

## Moved from !594

Opened on a compliant source branch. AGENTS.md 2.1 asks for a 3-5 word snake_case description and the previous branch had seven; GitLab cannot change an existing merge request's source branch, so the change moves rather than the name.

Same commits, rebased onto `c2a9768f`. Both code findings from the review on !594 are already in them -- `RecursionError` caught with its regression case, and the implementation comment reduced to the two non-obvious reasons. Nothing else changed, so that review carries.
2026-09-09 15:42:36 +00:00

231 lines
7.6 KiB
Python

"""qualified_id feedback dispatcher.
Exercises:
1. ``_filter_qualified_ids`` helper — prefix matching, native id
extraction, malformed input tolerance.
2. ``AgentLoop._dispatch_backend_feedback`` — only ``everos/*`` is
forwarded; ``local/`` / ``mass/`` / unprefixed entries are dropped
silently; backend exceptions swallowed.
"""
from __future__ import annotations
from pathlib import Path
from typing import Any
from raven.agent.loop import AgentLoop
from raven.agent.loop._shared import _filter_qualified_ids
from raven.agent.loop.bundles import EngineWiring, ToolWiring, TurnPolicy
# ---------------------------------------------------------------------------
# Helpers
# ---------------------------------------------------------------------------
class _StubProvider:
api_key = "test"
def get_default_model(self) -> str:
return "stub"
async def chat(self, *args, **kwargs):
raise NotImplementedError
async def chat_with_retry(self, *args, **kwargs):
raise NotImplementedError
class _FakeBackend:
def __init__(self) -> None:
self.feedback_calls: list[dict] = []
self.feedback_raises: Exception | None = None
async def start(self):
pass
async def stop(self):
pass
async def store(self, session_id, messages, *, metadata=None):
pass
async def recall(self, query, *, user_id=None, agent_id=None, top_k):
return []
async def feedback(self, signals: dict[str, Any]) -> None:
self.feedback_calls.append(signals)
if self.feedback_raises is not None:
raise self.feedback_raises
def _make_loop(workspace: Path, *, backend=None) -> AgentLoop:
return AgentLoop(
provider=_StubProvider(),
workspace=workspace,
model="stub",
policy=TurnPolicy(max_iterations=2),
tools=ToolWiring(restrict_to_workspace=True),
engine=EngineWiring(backend=backend),
)
# ---------------------------------------------------------------------------
# _filter_qualified_ids
# ---------------------------------------------------------------------------
class TestFilterQualifiedIds:
def test_extracts_native_for_matching_prefix(self) -> None:
out = _filter_qualified_ids(
["everos/abc", "local/x", "mass/y", "everos/def"],
"everos",
)
assert out == ["abc", "def"]
def test_returns_empty_when_no_match(self) -> None:
out = _filter_qualified_ids(
["local/x", "mass/y"],
"everos",
)
assert out == []
def test_none_input(self) -> None:
assert _filter_qualified_ids(None, "everos") == []
def test_empty_list(self) -> None:
assert _filter_qualified_ids([], "everos") == []
def test_unprefixed_legacy_id_skipped(self) -> None:
"""Legacy raw skill names (no ``<source>/`` prefix) are skipped
— there's no safe routing target for them, so the dispatcher
is conservatively silent rather than mis-routing."""
out = _filter_qualified_ids(
["git-resolver", "everos/abc"],
"everos",
)
assert out == ["abc"]
def test_malformed_entries_skipped(self) -> None:
out = _filter_qualified_ids(
["everos/", "everos/valid", "", None, 42, "everos/another"],
"everos",
)
# ``everos/`` (empty native) and non-strings drop.
assert out == ["valid", "another"]
def test_prefix_collision_avoided(self) -> None:
"""``everos`` is NOT a prefix of ``everos_light/...`` because
the separator is the slash. The helper compares against
``everos/`` literally."""
out = _filter_qualified_ids(
["everos_light/x", "everos/y"],
"everos",
)
assert out == ["y"]
# ---------------------------------------------------------------------------
# _dispatch_backend_feedback
# ---------------------------------------------------------------------------
class TestDispatcherFeedback:
async def test_no_backend_is_noop(self, tmp_path: Path) -> None:
agent = _make_loop(tmp_path, backend=None)
# Just returns without error.
await agent._dispatch_backend_feedback(
"s",
["everos/a"],
["everos/b"],
)
async def test_no_everos_ids_skips_backend(
self,
tmp_path: Path,
) -> None:
b = _FakeBackend()
agent = _make_loop(tmp_path, backend=b)
await agent._dispatch_backend_feedback(
"s",
["local/x", "mass/y"],
None,
)
# local/ + mass/ → no everos ids → no backend call.
assert b.feedback_calls == []
async def test_empty_ids_skips_backend(self, tmp_path: Path) -> None:
b = _FakeBackend()
agent = _make_loop(tmp_path, backend=b)
await agent._dispatch_backend_feedback("s", [], [])
assert b.feedback_calls == []
async def test_none_ids_skips_backend(self, tmp_path: Path) -> None:
b = _FakeBackend()
agent = _make_loop(tmp_path, backend=b)
await agent._dispatch_backend_feedback("s", None, None)
assert b.feedback_calls == []
async def test_everos_ids_forwarded(self, tmp_path: Path) -> None:
b = _FakeBackend()
agent = _make_loop(tmp_path, backend=b)
await agent._dispatch_backend_feedback(
"session-x",
injected_skill_ids=["local/a", "everos/inj1", "everos/inj2"],
used_skill_ids=["everos/used1"],
)
assert len(b.feedback_calls) == 1
signals = b.feedback_calls[0]
assert signals["kind"] == "skill_usage"
assert signals["session_id"] == "session-x"
assert signals["injected"] == ["inj1", "inj2"]
assert signals["used"] == ["used1"]
async def test_only_injected_no_used(self, tmp_path: Path) -> None:
"""The 'used' arg defaults to None — dispatch still fires if
injected has everos ids."""
b = _FakeBackend()
agent = _make_loop(tmp_path, backend=b)
await agent._dispatch_backend_feedback(
"s",
injected_skill_ids=["everos/x"],
)
assert len(b.feedback_calls) == 1
assert b.feedback_calls[0]["injected"] == ["x"]
assert b.feedback_calls[0]["used"] == []
async def test_backend_feedback_exception_swallowed(
self,
tmp_path: Path,
) -> None:
"""Feedback is best-effort telemetry — never aborts after-turn."""
b = _FakeBackend()
b.feedback_raises = RuntimeError("everos overloaded")
agent = _make_loop(tmp_path, backend=b)
# Returns normally despite the raise.
await agent._dispatch_backend_feedback("s", ["everos/x"], None)
# Backend was still hit (so we know exception came from feedback).
assert len(b.feedback_calls) == 1
async def test_signal_shape_stable_for_consumers(
self,
tmp_path: Path,
) -> None:
"""The forwarded signal dict has a documented shape that
EverosBackend (and future feedback consumers) can rely on."""
b = _FakeBackend()
agent = _make_loop(tmp_path, backend=b)
await agent._dispatch_backend_feedback(
"session-key",
injected_skill_ids=["everos/a"],
used_skill_ids=["everos/b"],
)
signals = b.feedback_calls[0]
assert set(signals.keys()) == {
"kind",
"session_id",
"injected",
"used",
}
assert isinstance(signals["injected"], list)
assert isinstance(signals["used"], list)