Review (unsupportedpastels) on #139311: a rerun over a main checkout moved it to v0.22.2, which was cut on release/0.22.1 and diverged from main, so the move crossed the gateway runtime cutover backwards without the downgrade guard `hermes update` runs before the same move (update_downgrade_guard refuses when a state.db holds session_admissions rows). The linear test history could not show it: there, "does not contain the release" always meant "behind it". A rerun now moves only when the release descends from HEAD. A checkout that contains it, has diverged from it, or cannot tell (shallow) stays, and `hermes update` decides that move with its guard; an explicit --channel stable is saved and left to `hermes update` the same way. The stable-default tests gain the release-branch shape (v0.22.2's): a rerun from main's tip keeps HEAD, a rerun from before the fork still moves.
80 lines
4.0 KiB
Python
80 lines
4.0 KiB
Python
"""A new or rerun install of the official repository lands on the latest stable release.
|
|
|
|
`hermes update` already follows stable for an official checkout that never chose a channel;
|
|
the installer has to put a fresh install there too, or new users start on main's tip. The
|
|
official URL is redirected to a local origin and `curl` answers the release lookup.
|
|
"""
|
|
from pathlib import Path
|
|
import os
|
|
import subprocess
|
|
|
|
import pytest
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
OFFICIAL = "https://github.com/NousResearch/hermes-agent.git"
|
|
|
|
pytestmark = pytest.mark.platforms("posix")
|
|
|
|
|
|
def _git(cwd, *args, env=None):
|
|
return subprocess.run(
|
|
["git", "-c", "user.name=Fixture", "-c", "user.email=fixture@example.invalid",
|
|
"-c", "commit.gpgsign=false", *args],
|
|
cwd=cwd, check=True, capture_output=True, text=True, stdin=subprocess.DEVNULL, env=env,
|
|
).stdout.strip()
|
|
|
|
|
|
@pytest.mark.parametrize("side,start,args,tagged,lands", [
|
|
(False, None, [], True, "release"), # fresh install: the release, not main's tip
|
|
(False, None, ["--channel", "main"], True, "tip"), # explicit opt-out: main's tip
|
|
(False, "before", [], True, "release"), # rerun behind the release: moves forward to it
|
|
(False, "tip", [], True, "tip"), # rerun already containing it: never moves back
|
|
(False, None, [], False, None), # release tag unreachable: fail, publish nothing
|
|
(False, "before", [], False, "before"), # ... a rerun keeps its checkout instead
|
|
# The release cut on a release branch, main past the fork point (v0.22.2's shape): main moves
|
|
# back only through `hermes update`, whose downgrade guard the installer cannot run.
|
|
(True, "tip", [], True, "tip"),
|
|
(True, "tip", ["--channel", "stable"], True, "tip"),
|
|
(True, "before", [], True, "release"),
|
|
])
|
|
def test_install_lands_on_the_latest_stable_release(tmp_path, side, start, args, tagged, lands):
|
|
origin, home, bin_dir = tmp_path / "origin", tmp_path / "home", tmp_path / "bin"
|
|
install = home / ".hermes" / "hermes-agent"
|
|
for d in (origin, home, bin_dir):
|
|
d.mkdir()
|
|
_git(origin, "init", "-q", "-b", "main")
|
|
_git(origin, "commit", "-q", "--allow-empty", "-m", "before")
|
|
if side:
|
|
_git(origin, "checkout", "-q", "-b", "release/1.2")
|
|
_git(origin, "commit", "-q", "--allow-empty", "-m", "release")
|
|
commits = {"before": _git(origin, "rev-parse", "HEAD~1"), "release": _git(origin, "rev-parse", "HEAD")}
|
|
if tagged:
|
|
_git(origin, "tag", "-a", "v1.2.3", "-m", "release")
|
|
_git(origin, "checkout", "-q", "main")
|
|
_git(origin, "commit", "-q", "--allow-empty", "-m", "newer")
|
|
commits["tip"] = _git(origin, "rev-parse", "HEAD")
|
|
(home / ".gitconfig").write_text(f'[url "file://{origin}"]\n insteadOf = {OFFICIAL}\n', encoding="utf-8")
|
|
(bin_dir / "curl").write_text(
|
|
'#!/bin/sh\ncase "$*" in *api.github.com*) printf \'{\\n "tag_name": "v1.2.3",\\n}\\n\';; *) exit 22;; esac\n',
|
|
encoding="utf-8")
|
|
(bin_dir / "curl").chmod(0o755)
|
|
env = {"PATH": f"{bin_dir}{os.pathsep}{os.environ['PATH']}", "HOME": str(home), "NO_COLOR": "1",
|
|
"GIT_CONFIG_NOSYSTEM": "1"}
|
|
if start:
|
|
install.parent.mkdir(parents=True)
|
|
_git(tmp_path, "clone", "-q", OFFICIAL, str(install), env=env)
|
|
_git(install, "checkout", "-q", "--detach", commits[start])
|
|
|
|
result = subprocess.run(
|
|
["bash", str(ROOT / "scripts" / "install.sh"), "--stage", "repository", "--dir", str(install),
|
|
"--hermes-home", str(home / ".hermes"), "--non-interactive", *args],
|
|
check=False, capture_output=True, text=True, stdin=subprocess.DEVNULL, timeout=120, env=env,
|
|
)
|
|
|
|
if lands is None:
|
|
assert result.returncode != 0 and not install.exists(), result.stdout + result.stderr
|
|
return
|
|
assert result.returncode == 0, result.stdout + result.stderr
|
|
assert _git(install, "rev-parse", "HEAD") == commits[lands], result.stdout + result.stderr
|
|
assert _git(install, "status", "--porcelain") == "", result.stdout + result.stderr
|