ytahdn efc86e0ea7
feat(web-shell): add /delete command with batch delete support (#4603)
* feat(web-shell): add /delete command with batch delete support

Add a /delete slash command to the web-shell that allows users to
permanently delete session data files. Supports both single-session
and multi-select batch deletion with proper error handling.

Changes:
- Add POST /sessions/delete batch endpoint to daemon server
- Add deleteSessionsData() to SDK DaemonClient
- Add DeleteSessionDialog with multi-select (Space to toggle, Enter
  to confirm) and search/filter support
- Add deleteSession/deleteSessions workspace actions and hooks
- Distinguish errors vs notFound in single-delete action (throw on
  real errors, return false only for notFound)
- Surface failure reasons in batch delete (allFailed / partialFail
  messages include first error detail)
- Normalize Error objects to string messages in server JSON response
- Add tests for server route, SDK client, and workspace provider

* fix(web-shell,cli): address PR review issues for batch delete

- Pass clientId to deleteSessionsData for ownership validation
- Add sessionIds max length (100) and deduplication
- Parallelize bridge.closeSession via Promise.allSettled
- Add server-side logging for close failures
- Reconcile selectedIds with search filter before delete
- Prune selectedIds when search query changes
- Fix notFound counting: only errors are failures
- Fix partial failure double toast: single error message
- Fix empty-state: show error message when load fails
- Fix hardcoded English "matches" → i18n key
- Remove dead targetSession parameter
- Align checkbox for current session ([-] instead of spaces)
- Add happy path test for batch delete
- Reload session list on notFound-only response

* fix(web-shell,cli): remove clientId ownership check for batch delete and improve UX

- Remove clientId validation from batch delete endpoint since workspace-level
  access is sufficient authorization. The per-tab clientId check prevented
  cross-tab deletion of active sessions without real security benefit (user
  can bypass by resuming the session first).
- Wrap filtered sessions list in useMemo to stabilize reference and prevent
  unnecessary keydown listener teardown/re-register on each render.
- Include notFound sessions in onDeleted callback so the toast correctly
  reports the total count of cleaned-up sessions.

Generated with AI

* fix(web-shell,cli): address round-2 review — logging, dead code, tests

- Add comment documenting intentional no-clientId in batch delete
- Log removeSessions filesystem errors to stderr for debuggability
- Count notFound as success in deleteSession for proper UI reload
- Remove dead if (!deleteSessions) / if (!deleteSession) guards
- Fix partial-failure double-wrapped toast message
- Reset selectedIdx when exiting search mode via Enter
- Add 5 batch tests: mixed outcomes, max-100 cap, non-string
  validation, dedup, and file preservation on error

Generated with AI

* fix(web-shell,cli): fix partial-failure toast and add 500 catch block test

- Revert partial-failure handler to use delete.partialFail i18n key
  through onError only, removing contradictory onDeleted call
- Add test for removeSessions unexpected throw (500 catch block)

* refactor(cli): use static import for SessionService in batch delete test

---------

Co-authored-by: ytahdn <ytahdn@gmail.com>
2026-05-30 11:38:07 +08:00
..
2026-05-27 10:32:17 +08:00
2026-05-27 10:32:17 +08:00
2026-05-27 10:32:17 +08:00
2026-05-27 10:32:17 +08:00
2026-05-27 10:32:17 +08:00
2026-05-27 10:32:17 +08:00