Convert gitgram/ and aitimemachine/ from embedded git repos (which showed as opaque submodule gitlinks on GitHub) into fully-tracked first-party content. AITM now merges its 7 vendored repos as first-party engines: - memory: beads (Go task DAG) + context7 (docs SDK), unified into saved_contexts - git: vendored C git (bundled binary) + gitnexus (in-process code intelligence) - agentic: a2a (@a2a-js/sdk) + pal (AITM-managed Python subprocess) Includes the full session's product build: Gitgram web/mobile/backend features, AITM website/CLI/MCP, the unified memory layer, engine build tooling (scripts/build-engines.sh, Dockerfile, CI), docs (README, ENGINES.md, ARCHITECTURE.md), and extensive test suites. Build artifacts, node_modules, external/, and gemini-cli are gitignored. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
76 lines
3.1 KiB
TypeScript
76 lines
3.1 KiB
TypeScript
/**
|
|
* JavaScript: CALLS-edge attribution for calls inside array higher-order-
|
|
* method callbacks (issue #1876).
|
|
*
|
|
* `const exportData = accountsList.map(account => transform(account))` matches
|
|
* the HOC-wrapped-arrow declaration pattern, so before this fix the JS scope
|
|
* model emitted a phantom `Function:exportData` for the `.map` callback (on
|
|
* top of the value binding). Calls nested in the callback (`transform`) then
|
|
* attributed to that phantom `Function` instead of the enclosing scope.
|
|
*
|
|
* U1 drops the `@declaration.function` for array-method callbacks, so the
|
|
* binding is value-only and the inner call falls through to the File scope —
|
|
* exactly the Zustand module-level-call behavior already pinned for TS.
|
|
*
|
|
* SCOPE: this asserts the scope-resolution CALLS-edge ATTRIBUTION change only.
|
|
* The duplicate *graph node* (`Function:exportData`) is created by the
|
|
* parse-worker node path, which this change does not touch; collapsing it is
|
|
* the deferred node-creation migration. Accordingly this file makes NO node-
|
|
* count assertion.
|
|
*
|
|
* The scope-resolution path attributes the inner call to the File scope rather
|
|
* than emitting the phantom attribution.
|
|
*/
|
|
import { describe, it, expect, beforeAll } from 'vitest';
|
|
import path from 'path';
|
|
import {
|
|
FIXTURES,
|
|
getRelationships,
|
|
runPipelineFromRepo,
|
|
type PipelineResult,
|
|
} from './resolvers/helpers.js';
|
|
|
|
describe('JavaScript array-method-callback CALLS attribution (#1876)', () => {
|
|
let result: PipelineResult;
|
|
|
|
beforeAll(async () => {
|
|
result = await runPipelineFromRepo(
|
|
path.join(FIXTURES, 'javascript-array-method-callback'),
|
|
() => {},
|
|
);
|
|
}, 60000);
|
|
|
|
it('control: run() body calls transform directly (resolver is wired)', () => {
|
|
const calls = getRelationships(result, 'CALLS').filter((c) => c.target === 'transform');
|
|
expect(calls.map((c) => `${c.source} → ${c.target}`)).toContain('run → transform');
|
|
});
|
|
|
|
it('call inside .map callback attributes to File, not a phantom Function:exportData', () => {
|
|
const calls = getRelationships(result, 'CALLS').filter((c) => c.target === 'transform');
|
|
const fromExportData = calls.filter((c) => c.source === 'exportData');
|
|
expect(
|
|
fromExportData,
|
|
'transform must NOT be attributed to exportData (phantom Function)',
|
|
).toEqual([]);
|
|
const fromFile = calls.filter((c) => c.sourceLabel === 'File');
|
|
expect(
|
|
fromFile,
|
|
'the .map callback call to transform must source from the File node (exactly once)',
|
|
).toHaveLength(1);
|
|
});
|
|
|
|
it('call inside .find callback attributes to File, not a phantom Function:firstActive', () => {
|
|
const calls = getRelationships(result, 'CALLS').filter((c) => c.target === 'predicate');
|
|
const fromFirstActive = calls.filter((c) => c.source === 'firstActive');
|
|
expect(
|
|
fromFirstActive,
|
|
'predicate must NOT be attributed to firstActive (phantom Function)',
|
|
).toEqual([]);
|
|
const fromFile = calls.filter((c) => c.sourceLabel === 'File');
|
|
expect(
|
|
fromFile,
|
|
'the .find callback call to predicate must source from the File node (exactly once)',
|
|
).toHaveLength(1);
|
|
});
|
|
});
|