4644 Commits

Author SHA1 Message Date
b2487e7740 fix: skip workspace members with no Raven User record in Open channels
raven.api.chat.get_channel_members built each Open-channel member's row by
indexing straight into the Raven User lookup result without checking it was
found, unlike the identical branch 10 lines below for non-Open channels. A
workspace member whose Raven User record is missing (e.g. left behind by a
direct cleanup that skipped RavenUser.on_trash's own cascade) crashes the
whole whitelisted endpoint with AttributeError instead of just being omitted.

Extracted the row-building into build_member_entry(), which returns None for
an unmatched member so both branches skip it the same way. Added
raven/tests/test_chat_channel_members.py (pure-function coverage plus an
IntegrationTestCase reproducing the stale-membership state) following this
repo's existing test conventions.

Verified: apps/web vitest (480/480) and tsc -b are unaffected and pass; the
new Python tests need a Frappe bench (DB-backed test runner) this sandbox
does not have, so they are written to the repo's established
IntegrationTestCase pattern but not executed here.
2026-10-21 03:59:57 +03:00
Nikhil Kothari
5c22932b44 chore: bump raven settings timestamp 2026-10-20 19:51:01 +05:30
Nikhil Kothari
f67b14bcad fix: do not show administrator and blur issue on Safari 2026-10-19 19:00:46 +05:30
Nikhil Kothari
9242c89a47 chore: update README 2026-10-19 13:03:05 +05:30
Nikhil Kothari
bf88a36fde chore: README rewrite, iPad fixes and Play Store release build
README: rewritten to the brand voice, with the new logo, Pilot as the
recommended install and a Frappe Cloud button. The old PNG logo is gone.

iPad: the primary rail now pads the status bar inset itself, since it
sits beside <main> and never got it. The bridge view controller overrides
supportedInterfaceOrientations because Capacitor builds its mask from the
iPhone list in Info.plist only, which pinned the iPad to portrait.

Android release: a signing config read from a gitignored
keystore.properties, and scripts/playstore.sh, which builds the signed
bundle the same way testflight.sh archives for iOS. Both are wired to
yarn native:playstore.

Build number 314 for both platforms.

Store screenshot tooling and the demo site seed are ignored; they are
local tooling, not part of the app.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-10-19 09:46:53 +05:30
Nikhil Kothari
fbd8c89a6c chore: update README 2026-10-18 01:46:06 +05:30
Nikhil Kothari
74b14bb09b
Merge pull request #2308 from frappe/onboarding
feat: onboarding
2026-10-18 01:32:09 +05:30
Nikhil Kothari
44e58237da fix(setup): stop the team step re-rendering itself
The chosen site users were filtered afresh each render, so the preview
effect fired every time, set state in the page, and re-rendered the step
again. Memoized on the list and the selection.
2026-10-18 01:31:57 +05:30
Nikhil Kothari
b6d1f08ba0 fix(setup): don't let a Raven Admin's default selection fail the add
Giving someone Raven access saves their User, which needs System
Manager. Setup admits Raven Admins too, and everyone starts ticked, so
their first Add raised for the whole batch, including people already in
Raven who only needed a membership. People still needing access are now
offered but not addable to a caller who can't write Users, and the row
says so.
2026-10-18 01:31:09 +05:30
Nikhil Kothari
022a179b2f fix: move create channel outside empty state 2026-10-18 00:56:54 +05:30
Nikhil Kothari
29be39e360 feat(setup): choose who joins, report the funnel, fix photos, HR copy
Install no longer adds every system user it can and skips the rest.
Raven ships Raven User and Raven Admin role profiles, and the team step
opens a searchable picker, with Select all, over everyone on the site;
a single person gets a checkbox. One helper now gives Raven access
everywhere: a user whose roles come from a role profile gets Raven's
profile alongside, which the Framework keeps across saves; on Frappe 15,
where a user has one profile, they're shown but not addable. Someone
whose Raven access was taken away is offered again.
The setup funnel is reported as the Framework wizard reports its own:
each step completed or skipped with the time spent, going back, starting
and leaving. The web app posts them to one endpoint that passes known
events and properties to the Framework's capture.
A public photo on the User is used as it is on the Raven User; the old
copy fetched the file from the site itself, which fails on a dev server
and was swallowed. Setup also falls back to the User's photo.
The HR step's copy is rewritten.
2026-10-18 00:53:13 +05:30
Nikhil Kothari
1d01647904 fix: empty states on a fresh site
Found while walking a new site through setup:

- The DM sidebar showed only "No conversations yet" when there were no
  DMs. The start-a-conversation rows were the virtual list's footer, so
  they never rendered for an empty list. They now show in that case too;
  the empty state is kept for when there's no one to suggest.
- The command menu's "Users" heading rendered over nothing on a site with
  no DMs, as cmdk only hides an empty group while searching.
- "Select a conversation" now sits in the page's island, where the chat
  would be, instead of floating on the canvas.
- Icons on "Select a conversation" and "No messages yet".
- The channel sidebar's empty state is sized for the narrow column, held
  near the top, and offers a Create a channel button.
2026-10-17 23:38:54 +05:30
Nikhil Kothari
7646fc98fb feat(setup): a calmer ending
After the last step the form gives way to a check that draws itself and
"All done", which fades out and is replaced by "Now, send a raven." in
Newsreader, the rest of the line following the "Now,". Both lines share
one slot so nothing shifts. The preview then grows into the app as
before. The finale timers now run through one helper.
2026-10-17 23:29:54 +05:30
Nikhil Kothari
aa8e33d25b fix(install): import system users before settings defaults are stored
get_single_value reads nothing for a single with no stored rows, and
Frappe stores defaults only after after_install, so the import skipped
everyone on a fresh site. Read the setting through the document, which
applies its default.
2026-10-17 22:34:49 +05:30
Nikhil Kothari
ef2ecda6e9 fix(setup): read the Framework setup flag where the app's boot puts it
The app's slim boot carries setup_complete only under sysdefaults, so
the gate sent pending admins to the Desk wizard on sites already set up.
The slim boot also gains is_fc_site, which the gate and the password
step read.
2026-10-17 22:32:20 +05:30
Nikhil Kothari
074a70ef35 fix(setup): let the profile step recover from a failed fetch
The profile hook doesn't retry, so one failed request left the first
step blank with no way on. The step now shows the error with a Retry.
2026-10-17 22:29:44 +05:30
Nikhil Kothari
c1194550d5 fix(setup): keep setup state per site in the app
The app serves every site from one origin, so the done flag, the saved
progress and the boot-cache update were shared across sites. All three
now use the site-scoped key. The workspace step also prefills the company
in the fetch's onSuccess instead of an effect.
2026-10-17 22:28:33 +05:30
Nikhil Kothari
49cb326153 refactor(setup): track setup as completed, not pending
A blank flag on a fresh install already means "not set up", so the
installer no longer stores settings just to raise one. Sites already
running Raven are marked completed by a patch instead.
2026-10-17 22:15:53 +05:30
Nikhil Kothari
fc70ca23b3 eat(setup): run a Frappe Cloud signup through Raven's setup
Frappe Cloud opens a new site on /raven before the Framework wizard. The
gate now lets those sites into Raven's flow, the profile step asks the
first admin for a password since no wizard did, and finishing Raven's
setup completes the Framework wizard with the region Frappe Cloud stored.
Sites with ERPNext or HRMS still go through the real wizard first.
2026-10-17 22:08:07 +05:30
Nikhil Kothari
66eec8e7a6 fix: run the setup flow on every fresh install
The v15 gate made older sites keep the default "Raven" workspace and skip
setup. Nothing in the flow needs Frappe 16, so every new site now starts
with setup pending and no default workspace.
2026-10-17 21:42:37 +05:30
Nikhil Kothari
ffe52c09d6 Merge remote-tracking branch 'frappe/develop' into onboarding 2026-10-17 03:26:07 +05:30
Nikhil Kothari
3f8b83641b chore(native): build 313 2026-10-17 03:04:35 +05:30
Nikhil Kothari
7fe751f48b fix(mobile): site picker UI 2026-10-17 02:48:52 +05:30
Nikhil Kothari
9afb5b99c0 feat(native): create the app's OAuth client on install and on migrate 2026-10-17 02:44:02 +05:30
Nikhil Kothari
6218c92bb6 chore: remove tenor API key 2026-10-17 02:38:40 +05:30
Nikhil Kothari
cbaaec4add
Merge pull request #2265 from frappe/native-bundled
feat: mobile app
2026-10-17 02:28:12 +05:30
Nikhil Kothari
3825dc0c28 chore: release 3.1.0 and require it on both sides of the native app
The web app, the native bundle and the store versions move to 3.1.0.
A 3.1.0 site asks apps older than that to update, and the app refuses
sites below 3.1.0 in the picker: the native boot endpoint and the CORS
hook only ship from there, so an older site could not open anyway.
2026-10-17 02:27:40 +05:30
Nikhil Kothari
3f8723c963 fix(ios): delete shared copies once read and drop the previous share
Every share wrote a new folder into the app group and nothing removed
it. The page now deletes each copy once its bytes are in memory, and the
extension clears the previous share before writing a new one, as the
Android shell already does. Only the latest share is ever readable, so
nothing reachable is lost.
2026-10-17 02:11:46 +05:30
Nikhil Kothari
ea1eb2c459 fix(ios): copy shared files without reading them into memory
The share extension loaded each file-backed item into Data before
writing it to the app group, which breached the extension's memory
limit on large videos and ended the share. The copy now streams through
the file manager; Data is kept only for items that exist nowhere on disk.
2026-10-17 02:07:53 +05:30
Nikhil Kothari
9dc073a915 fix(native): hand shared files only to the conversation the user picks
The share page stashed files globally as soon as it loaded, so backing
out left them for the next composer to attach in any conversation. The
page now keeps the files until a conversation is picked and stashes them
for that channel alone; a composer takes only files addressed to it.
2026-10-17 02:03:11 +05:30
Aditya Patil
4f39d52c62 fix: merge conflict 2026-10-17 02:01:36 +05:30
Aditya Patil
b008a010a0 Merge remote-tracking branch 'origin/develop' into onboarding 2026-10-17 02:00:54 +05:30
Nikhil Kothari
6f6d7e608c fix(native): keep listening for FCM token rotation after a first enable
The rotation listener was only installed when push was already on at
startup, so a session that enabled push for the first time kept a dead
token on the server until the next restart. One watcher now serves both
paths, and it only syncs while push is on for the site, so a rotation
after turning push off does not subscribe the device again.
2026-10-17 02:00:24 +05:30
Aditya Patil
5a13290655 fix: implement busy state reporting across setup steps and enhance channel preview styling 2026-10-17 01:57:01 +05:30
Nikhil Kothari
7016ab9881 chorw: re-run patch for oauth redirect 2026-10-17 01:23:46 +05:30
Nikhil Kothari
4db08c0825 fix(push): name the site only in titles for mobile devices 2026-10-17 01:20:28 +05:30
Nikhil Kothari
d15f7676e6 fix(native): drop the duplicate before_request hook and clarify the app header
hooks.py registered set_cors twice after the merge; develop already has
it. The X-Raven-App comment now says what the header is for: it marks a
request as the app's, and the origin allowlist is what actually limits
CORS.
2026-10-17 01:07:23 +05:30
Nikhil Kothari
2f1a8e8e52 fix(native): bundle the Newsreader font instead of reading it from raven/public 2026-10-17 01:02:05 +05:30
Aditya Patil
d8e45c3baa fix: workspace description takes input after the company prefill 2026-10-17 00:59:53 +05:30
Nikhil Kothari
804354f696 Merge remote-tracking branch 'frappe/develop' into native-bundled
# Conflicts:
#	apps/web/src/components/features/ChatInput/composerGate.tsx
#	apps/web/src/components/features/message/ChatStream.tsx
#	package.json
#	yarn.lock
2026-10-17 00:49:40 +05:30
Aditya Patil
86784f0a82 fix: setup edge cases 2026-10-17 00:35:51 +05:30
Aditya Patil
c9447d3718 fix: workspace name in preview 2026-10-17 00:05:18 +05:30
Aditya Patil
b931ce9425 refactor: clean up setup logic and remove unused dev testing function 2026-10-16 23:55:31 +05:30
Aditya Patil
a7c30b982a WIP: finish transition and fixes 2026-10-16 23:47:39 +05:30
Aditya Patil
3bac23d757 WIP: HR step 2026-10-16 22:42:22 +05:30
Aditya Patil
f288695cf4 WIP: profile step 2026-10-16 20:15:01 +05:30
Aditya Patil
523a36edbf WIP: workspace step styling 2026-10-16 18:45:25 +05:30
Aditya Patil
72b6168e8b WIP: setup steps 2026-10-16 18:33:14 +05:30
Nikhil Kothari
23eeebe326
fix: clean up multiple long-standing issues (#2311)
* fix: do not allow sending messages to disabled users

* fix: message action toolbar position in left-right mode

* fix: show timestamp for continuation messages

* fix: do not enforce max length on password fields

* fix: Raven logo sizing and welcome text

* fix: limit raven document notifications to stop at cacading error logs

* fix: do not leave channel references in notifications when channel is deleted

* fix: handle raven user deletion by removing role

* fix: set dm_user_1 and 2 to None explicitly

* fix: in-desk integration

* fix: allow Cyrillic characters in channel name

* fix: cap width to container

* fix: enable user via roles
2026-10-16 18:30:38 +05:30
Aditya Patil
53aa418143 WIP: split-view setup page with step fades 2026-10-16 16:49:26 +05:30