This repository has been archived on 2026-11-17. You can view files and clone it, but cannot push or open issues or pull requests.
caelum0x 49b183818c Unify gitgram + aitimemachine into the monorepo (de-submodule) and merge vendored engines
Convert gitgram/ and aitimemachine/ from embedded git repos (which showed as
opaque submodule gitlinks on GitHub) into fully-tracked first-party content.

AITM now merges its 7 vendored repos as first-party engines:
- memory: beads (Go task DAG) + context7 (docs SDK), unified into saved_contexts
- git: vendored C git (bundled binary) + gitnexus (in-process code intelligence)
- agentic: a2a (@a2a-js/sdk) + pal (AITM-managed Python subprocess)

Includes the full session's product build: Gitgram web/mobile/backend features,
AITM website/CLI/MCP, the unified memory layer, engine build tooling
(scripts/build-engines.sh, Dockerfile, CI), docs (README, ENGINES.md, ARCHITECTURE.md),
and extensive test suites.

Build artifacts, node_modules, external/, and gemini-cli are gitignored.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 14:14:09 +03:00

1.9 KiB

Linting Policy

Last reviewed: 2026-05-29

Freshness source: .golangci.yml, .github/workflows/pr.yml, .github/workflows/main.yml, and golangci-lint run --timeout=5m --build-tags=gms_pure_go ./... returning zero issues.

This document explains the required Go lint gate for this codebase.

Current Status

Lint is a required CI gate. The PR and main workflows run golangci-lint with the repository configuration and --build-tags=gms_pure_go; it is expected to pass with zero issues.

Run the same check locally with:

golangci-lint run --timeout=5m --build-tags=gms_pure_go ./...

Formatting is a separate required gate:

make fmt-check

Policy

Treat new lint findings as defects to fix before merge. Do not add a tolerated failing baseline, and do not configure CI with --issues-exit-code=0.

When a linter reports an intentional or false-positive pattern:

  • Prefer a narrow .golangci.yml exclusion tied to a path, linter, and message.
  • Use //nolint:<linter> only when the reason is local to a specific line and the comment explains why the warning is not actionable.
  • Keep broad linter disables as a last resort.

The current configuration already encodes accepted exclusions for intentional patterns such as deferred cleanup errors, controlled subprocess execution, test-fixture file reads, and documented security false positives.

CI Cleanup Decision

pr-lint should stay separate from pr-policy and pr-core so failures are easy to identify and rerun. It should include:

  • make fmt-check
  • golangci-lint run --timeout=5m --build-tags=gms_pure_go ./...

See CI_CLEANUP_PLAN.md for the full CI tier policy.

Future Work

  • Pin the golangci-lint version in CI instead of using version: latest.
  • Move the final CI shape behind a repository-owned scripts/ci/pr-lint.sh wrapper.
  • Periodically audit .golangci.yml exclusions and remove entries that are no longer needed.